[Spice-devel] [PATCH spice-gtk 1/2] channel-usbredir: Rename spice_usbredir_write_callback

[Victor Toso]

Hi,

On Thu, Sep 05, 2019 at 11:02:44AM +0100, Frediano Ziglio wrote:
> Remove "_callback" suffix.
> The function is called directly, no much reasons to keep that
> suffix.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Victor Toso <victortoso at redhat.com>
> ---
>  src/channel-usbredir-priv.h | 2 +-
>  src/channel-usbredir.c      | 2 +-
>  src/usb-backend.c           | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/channel-usbredir-priv.h b/src/channel-usbredir-priv.h
> index a36f5d9b..1230628c 100644
> --- a/src/channel-usbredir-priv.h
> +++ b/src/channel-usbredir-priv.h
> @@ -70,7 +70,7 @@ void spice_usbredir_channel_get_guest_filter(
>                            int                                *rules_count_ret);
>  
>  /* Callback for USB backend */
> -int spice_usbredir_write_callback(SpiceUsbredirChannel *channel, uint8_t *data, int count);
> +int spice_usbredir_write(SpiceUsbredirChannel *channel, uint8_t *data, int count);
>  
>  G_END_DECLS
>  
> diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
> index 8d4cd664..0a711c25 100644
> --- a/src/channel-usbredir.c
> +++ b/src/channel-usbredir.c
> @@ -572,7 +572,7 @@ static int try_write_compress_LZ4(SpiceUsbredirChannel *channel, uint8_t *data,
>  #endif
>  
>  G_GNUC_INTERNAL
> -int spice_usbredir_write_callback(SpiceUsbredirChannel *channel, uint8_t *data, int count)
> +int spice_usbredir_write(SpiceUsbredirChannel *channel, uint8_t *data, int count)
>  {
>      SpiceMsgOut *msg_out;
>  
> diff --git a/src/usb-backend.c b/src/usb-backend.c
> index cfd14e2c..dbc96194 100644
> --- a/src/usb-backend.c
> +++ b/src/usb-backend.c
> @@ -614,7 +614,7 @@ static int usbredir_write_callback(void *user_data, uint8_t *data, int count)
>      SpiceUsbBackendChannel *ch = user_data;
>      int res;
>      SPICE_DEBUG("%s ch %p, %d bytes", __FUNCTION__, ch, count);
> -    res = spice_usbredir_write_callback(ch->user_data, data, count);
> +    res = spice_usbredir_write(ch->user_data, data, count);
>      return res;
>  }
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190905/8488ad4e/attachment.sig>