[Spice-devel] [PATCH spice-common v2] common/recorder.h: do not complain on unused (dummy) recorders

Frediano Ziglio fziglio at redhat.com
Wed Sep 11 09:12:34 UTC 2019


> 
> Signed-off-by: Kevin Pouget <kpouget at redhat.com>

Acked

> ---
>  common/recorder.h | 3 ++-
>  tests/Makefile.am | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/common/recorder.h b/common/recorder.h
> index 98b8797..8448e02 100644
> --- a/common/recorder.h
> +++ b/common/recorder.h
> @@ -20,6 +20,7 @@
>  
>  #include <stdio.h>
>  #include <stdint.h>
> +#include <spice/macros.h>
>  
>  /* Replacement declarations.
>   * There declarations should generate no code (beside when no optimization
>   are
> @@ -45,7 +46,7 @@ typedef struct SpiceDummyTweak {
>  #define RECORDER(rec, num_rings, comment) \
>      RECORDER_DEFINE(rec, num_rings, comment)
>  #define RECORDER_DEFINE(rec, num_rings, comment) \
> -    const SpiceEmptyStruct spice_recorder_ ## rec = {}
> +    const SpiceEmptyStruct SPICE_GNUC_UNUSED spice_recorder_ ## rec = {}
>  #define RECORDER_TRACE(rec) \
>      (sizeof(spice_recorder_ ## rec) != sizeof(SpiceEmptyStruct))
>  #define RECORDER_TWEAK_DECLARE(rec) \
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 4b8bcf4..0d75d6b 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -73,6 +73,7 @@ test_dummy_recorder_SOURCES =		\
>  	$(NULL)
>  test_dummy_recorder_CFLAGS =		\
>  	-I$(top_srcdir)			\
> +	$(PROTOCOL_CFLAGS)              \
>  	$(NULL)
>  test_dummy_recorder_LDADD =				\
>  	$(top_builddir)/common/libspice-common.la	\



More information about the Spice-devel mailing list