[Spice-devel] [PATCH spice-server] red-qxl: Make sure we have at least one monitor

Victor Toso victortoso at redhat.com
Thu Sep 19 13:04:09 UTC 2019


On Thu, Sep 19, 2019 at 11:17:25AM +0100, Frediano Ziglio wrote:
> It does not make sense to have a graphic card without a monitor.
> In spice_qxl_set_max_monitors we prevent to set 0 monitors, do
> the same in spice_qxl_set_device_info.
> 
> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1691721.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  server/red-qxl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red-qxl.c b/server/red-qxl.c
> index 03348270..dbfcd440 100644
> --- a/server/red-qxl.c
> +++ b/server/red-qxl.c
> @@ -804,7 +804,7 @@ void spice_qxl_set_device_info(QXLInstance *instance,
>      }
>  
>      instance->st->monitors_count = device_display_id_count;
> -    instance->st->max_monitors = device_display_id_count;
> +    instance->st->max_monitors = MAX(1u, device_display_id_count);
>  
>      reds_send_device_display_info(red_qxl_get_server(instance->st));
>  }
> -- 
> 2.21.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190919/53af2723/attachment.sig>


More information about the Spice-devel mailing list