[Spice-devel] [PATCH spice-gtk] spicy: Do not call gst_init directly

[Victor Toso]

On Tue, Sep 10, 2019 at 10:21:34AM +0100, Frediano Ziglio wrote:
> GStreamer is already initialized using gst_init_get_option_group and
> gst_init_get_option_group.
> 
> From gst_init documentation:
>    WARNING: This function does not work in the same way as
>    corresponding functions in other glib-style libraries,
>    such as gtk_init(). In particular, unknown command line options
>    cause this function to abort program execution.
> 
> This luckily is not true (program won't abort if you pass --gst-foo
> for instance) but better to stick to documentation.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Victor Toso <victortoso at redhat.com>
> ---
>  tools/spicy.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/spicy.c b/tools/spicy.c
> index 403a66d1..8ca62f91 100644
> --- a/tools/spicy.c
> +++ b/tools/spicy.c
> @@ -2017,7 +2017,6 @@ int main(int argc, char *argv[])
>  
>      /* parse opts */
>      gtk_init(&argc, &argv);
> -    gst_init(&argc, &argv);
>      context = g_option_context_new("- spice client test application");
>      g_option_context_set_summary(context, "Gtk+ test client to connect to Spice servers.");
>      g_option_context_set_description(context, "Report bugs to " PACKAGE_BUGREPORT ".");
> -- 
> 2.21.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190923/0f7699af/attachment.sig>