[Spice-devel] [spice 3/8] tests: migrate: add support to run with remote-viewer

[Victor Toso]

Hi,

On Wed, Sep 25, 2019 at 05:29:56AM -0400, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me at victortoso.com>
> > 
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  tests/migrate.py | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/migrate.py b/tests/migrate.py
> > index 5a0f5930..f893b2ac 100755
> > --- a/tests/migrate.py
> > +++ b/tests/migrate.py
> > @@ -58,7 +58,7 @@ def get_args():
> >      parser.add_argument('--qemu', dest='qemu',
> >      default='../../qemu/x86_64-softmmu/qemu-system-x86_64')
> >      parser.add_argument('--log_filename', dest='log_filename',
> >      default='migrate.log')
> >      parser.add_argument('--image', dest='image', default='')
> > -    parser.add_argument('--client', dest='client', default='spicy',
> > choices=['spicy'])
> > +    parser.add_argument('--client', dest='client', default='spicy',
> > choices=['spicy', 'remote-viewer'])
> >      parser.add_argument('--vdagent', choices=['on', 'off'], default='on')
> >      args = parser.parse_args(sys.argv[1:])
> >      if os.path.exists(args.qemu):
> > @@ -97,6 +97,9 @@ def start_qemu(qemu_exec, image, spice_port, qmp_filename,
> > incoming_port=None, e
> >  
> >  def start_client(client, spice_port):
> >      client_cmd = "spicy --uri spice://localhost:%s" % (spice_port)
> > +    if client == "remote-viewer":
> > +        client_cmd = "%s spice://localhost:%s" % (client, spice_port)
> 
> Maybe here can just be
> 
>   client_cmd = "remote-viewer spice://localhost:%s" % (spice_port)

Ah, yes, before it was != "spicy" but I changed.
Either way is fine for me.

> > +
> >      return Popen(client_cmd.split(), executable=client)
> >  
> >  def wait_active(q, active):
> 
> Otherwise,
>   Acked-by: Frediano Ziglio <fziglio at redhat.com>
> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190925/bf44dbd3/attachment.sig>