[Spice-devel] [spice 7/8] tests: migrate: add option to wait user input

Frediano Ziglio fziglio at redhat.com
Wed Sep 25 09:34:33 UTC 2019


> 
> From: Victor Toso <me at victortoso.com>
> 
> The iterate() method already considers it. This is useful if one wants
> to attach gdb on qemu for instance.
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  tests/migrate.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/migrate.py b/tests/migrate.py
> index 4ac6289b..fcf51bdb 100755
> --- a/tests/migrate.py
> +++ b/tests/migrate.py
> @@ -60,6 +60,8 @@ def get_args():
>      parser.add_argument('--client', dest='client', default='spicy',
>      choices=['spicy', 'remote-viewer'])
>      parser.add_argument('--vdagent', dest="vdagent", action='store_true',
>      default=False,
>                          help="Append options for agent's virtserialport")
> +    parser.add_argument('--wait-to-start', dest="wait_user_input",
> action='store_true', default=False,
> +                        help="Wait user's input to start migration test")

The variable name and comment are "wait user input", the option is
"wait to start". Why different ?

>      args = parser.parse_args(sys.argv[1:])
>      if os.path.exists(args.qemu):
>          args.qemu_exec = args.qemu
> @@ -214,7 +216,7 @@ def main():
>          args.spice_port2], vdagent=args.vdagent)
>      atexit.register(cleanup, migrator)
>      while True:
> -        migrator.iterate()
> +        migrator.iterate(args.wait_user_input)
>  
>  if __name__ == '__main__':
>      main()

Otherwise,
  Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list