[Spice-devel] [spice v2 2/8] tests: migrate: use uri for default's spicy client

Uri Lublin uril at redhat.com
Thu Sep 26 12:13:42 UTC 2019


On 9/25/19 1:02 PM, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> Acked-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>   tests/migrate.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/migrate.py b/tests/migrate.py
> index 0c302c92..5a0f5930 100755
> --- a/tests/migrate.py
> +++ b/tests/migrate.py
> @@ -96,8 +96,8 @@ def start_qemu(qemu_exec, image, spice_port, qmp_filename, incoming_port=None, e
>       return proc
>   
>   def start_client(client, spice_port):
> -    return Popen(("%(client)s -h localhost -p %(port)d" % dict(port=spice_port,
> -        client=client)).split(), executable=client)
> +    client_cmd = "spicy --uri spice://localhost:%s" % (spice_port)
> +    return Popen(client_cmd.split(), executable=client)

Hi,

Since you remote-viewer is made available as a client on the next patch,
you can leave '%(client)s ' as is and not replace it with 'spicy'.

That also makes the next patch smaller.

Uri.

>   
>   def wait_active(q, active):
>       events = ["RESUME"] if active else ["STOP"]
> 



More information about the Spice-devel mailing list