[Spice-devel] [PATCH 2/6] drm: Add drm_simple_encoder_{init, create}()

[Ville Syrjälä]

On Fri, Feb 07, 2020 at 02:37:20PM +0100, Daniel Vetter wrote:
> On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote:
> > The simple-encoder helpers initialize an encoder with an empty
> > implementation. This covers the requirements of most of the existing
> > DRM drivers. A call to drm_simple_encoder_create() allocates and
> > initializes an encoder instance, a call to drm_simple_encoder_init()
> > initializes a pre-allocated instance.
> > 
> > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> 
> This has quick a bit midlayer taste to it ... I think having this as a
> helper would be cleaner ...
> 
> The other bit is drm_encoder->possible_crtcs. If we do create a helper for
> these, lets at least try to make them not suck too badly :-) Otherwise I
> guess it would be time to officially document what exactly possible_crtcs
> == 0 means from an uabi pov.

I had some improvements for this stuff. Just re-sent the remainder.

-- 
Ville Syrjälä
Intel