[Spice-devel] About decisions and reviews

[Daniel P. Berrangé]

On Mon, May 11, 2020 at 12:16:24PM +0200, Marc-André Lureau wrote:
> Hi,
> 
> About "Move code to C++":
> https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62
> 
> I would like to know how the decision happened. As long as I have been
> involved in the Spice project, we had open discussions and did
> mandatory review for anything non-trivial.
> 
> This change is substantial, and impacts the work and contribution of
> others. Where did the discussion happen? Who reviewed the code
> changes?

Looking at that merge request, it is pretty surprising to see a 100
patch long series merged with no review comments visible on the code
from other maintainers.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|