[Spice-devel] Bug in qxl kernel driver (bpp)

[Frediano Ziglio]

> Hi folks,

> The Xorg log is getting spammed with the following messages (I noticed I'm
> not the only one on the Internet):

> > qxl_surface_create: Bad bpp: 1 (1)
> 
> > qxl_surface_create: Bad bpp: 1 (1)
> 
> > qxl_surface_create: Bad bpp: 1 (1)
> 
> I think this isn't nice for anyone. So I propose a fix in the driver around
> here :
> https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/qxl/qxl_cmd.c#L396
> A valid value of Bits per pixel (bpp aka Pixelmap) is often 24 (or 32 bit
> depth). Please try to play around with this, and see if you could make Xorg
> server happy again.

> Thanks!

> Regards,
> Melroy van den Berg

Hi,
  the "bpp" value does not arrive to the kernel so there's no point to update it.
It arrives from some other calls in the driver. I think the function to be changed
should qxl_create_pixmap in the Xorg driver (src/qxl_uxa.c).

Regards,
  Frediano