[Spice-devel] spice-vdagent: how to enable additional mouse buttons?

Thu May 14 14:45:00 UTC 2020

Good afternoon Kevin,

That is some great news! Let me get to testing this on my side and give you feedback on it.

It makes sense people want their other mouse buttons to work on a guest system, so your work on this will for sure be worth the time and will make many people happy I am sure.

I will get back to you asap, thanks so much!

Roger

De : Kevin Pouget <kpouget at redhat.com>
À : bruts at netc.fr
Sujet : Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?
Date : 14/05/2020 16:37:36 Europe/Paris
Copie à : Frediano Ziglio <fziglio at redhat.com>;
   Spice devel <spice-devel at lists.freedesktop.org>

Hello,

I've pushed some commits to get the mouse buttons working with the VDAgent (and only it, some bits are missing in spice-server to handle the other types I think):

https://gitlab.freedesktop.org/kpouget/spice/-/commits/exp/mouse-bt

https://gitlab.freedesktop.org/kpouget/spice-gtk/-/commits/exp/mouse-bt

https://gitlab.freedesktop.org/kpouget/spice-protocol/-/commits/exp/mouse-bt

https://gitlab.freedesktop.org/kpouget/vd_agent/-/tree/exp/mouse-bt

and I uploaded a small demo of the way it works in my workstation: my mouse has 2 extra buttons (8 and 9) that are properly forwarded

> http://people.redhat.com/~kpouget/20-05-14/mouse-bt.mkv 

I hope it will work the same on your side!

On Wed, May 13, 2020 at 11:20 AM <bruts at netc.fr> wrote:

Hi Kevin and Frediano,

Yes there might be issues like Frediano is pointing out, probably they are not well defined, so it might be not trivial to create something for the public out of this.

Still I wonder why there are these entries in /usr/include/linux/input-event-codes.h:
#define BTN_MOUSE               0x110
#define BTN_LEFT                0x110
#define BTN_RIGHT               0x111
#define BTN_MIDDLE              0x112
#define BTN_SIDE                0x113
#define BTN_EXTRA               0x114
#define BTN_FORWARD             0x115
#define BTN_BACK                0x116
#define BTN_TASK                0x117

They must have some meaning no? Perhaps they are matched to different mouse buttons, like one time to button 8, the other mouse declares it as button 10, that is what you mean?

Still I would be very happy if Kevin would have the time to make a little patch, or an approach to that little patch, so I could use it for my individual mouse buttons, I understand it is not easy to get this out to the public, still if there is a patch available in the mailing list, then at least people can grab that and change it to their liking, right?

Anyway, all the replies and help is appreciated! Let's get my thumb happy and give him that mouse button ;)

De : Frediano Ziglio <fziglio at redhat.com>
À : Kevin Pouget <kpouget at redhat.com>
Sujet : Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?
Date : 13/05/2020 09:49:45 Europe/Paris
Copie à : bruts at netc.fr;
   Spice devel <spice-devel at lists.freedesktop.org>

Hi,

  if I remember I think the main issue is that these buttons are kind of wild west.

Basically what is button 6 (first 5 are well defined) ? It can be anything so it could

be that for instance my client left becomes right on the guest.

Maybe just changing mouse model the semantic of the buttons on the guest change.

Also I remember that GTK had some problems, these buttons are not defined, I think

they are passed from the underlying system (Windows, X11, Wayland).

However I see two "workaround":

1- let the users take care of the mismatch. Either getting used to use a button

   instead of the other or using some tools;

2- add a message to communicate the meaning of the various buttons (which can

   change for instance changing mouse).

I think 1 is what was implemented by the patches, I'd go for this way.

I hope softwares are not associating button semantics to computer shutdown

or something "dangerous" like this.

Frediano

On Tue, May 12, 2020 at 11:58 PM <bruts at netc.fr> wrote:

Hi Victor,

Yes it was certainly a good read and i got some ideas from it, but the code has changed quite a lot since 2017 and the patches correspond to the current code only for about 10-15%.

Maybe someone from the Spice team can suggest a patch to add additional mouse buttons - i am sure that it would be a matter of minutes to an hour for anyone who is involved with coding the spice-vdagent project to create a general patch idea to add additional mouse buttons

Hello,

I'll give it a try this morning, indeed it shouldn't require (much|any) new code, only flags here and there. Let's see

Kevin

It is just a matter of forwarding them to the guest - for some reason it was decided not to add them.

thanks!

De : Victor Toso <victortoso at redhat.com>
À : bruts at netc.fr
Sujet : Re: [Spice-devel] spice-vdagent: how to enable additional mouse buttons?
Date : 12/05/2020 07:25:59 Europe/Paris
Copie à : uril at redhat.com;
   spice-devel at lists.freedesktop.org

Hi,

On Tue, May 12, 2020 at 12:53:02AM +0200, bruts at netc.fr wrote:
> 
> 
> Uri (and others),
> 
> I found the similar question in a few corners of the internet
> and I think adding at least the additional default mouse
> buttons should not be all that much work.

You can take a look at this proposal to adding horizontal wheel
support to Spice

https://lists.freedesktop.org/archives/spice-devel/2017-October/040558.html

> With some guidance I could probably do it myself, though the
> guidance would need to be quite substantial :)
> 
> The mouse and the main buttons is already forwarded and that is
> the main part.
> 
> with xev it is clear to see which buttons work on the host, but
> not on the guest.
> 
> Anyone with some spare time (which I know is always limited for
> everyone), but help me where to fix this in the code and i will
> write a patch - or give me a good start - or start yourself.
> 
> a semi working mouse in the guest is very annoying and can be
> one of the critical points why to use spice (or not) - at least
> i know it is in my case.
> 
> Thanks!!

Cheers,
Victor

_______________________________________________
Spice-devel mailing list
Spice-devel at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

_______________________________________________
Spice-devel mailing list
Spice-devel at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20200514/aa6bd380/attachment.htm>