[Spice-devel] [PATCH] reset qxl to vga mode

[Frediano Ziglio]

Il giorno mar 14 feb 2023 alle ore 10:50 qi zhou <atmgnd at outlook.com>
ha scritto:
>
> > Hi,
> >   It looks good to me. Why it was QXL_IO_MEMSLOT_ADD I don't know. On
> > Linux is QXL_IO_RESET too.
>
> May be a typo ?, here you can use sysinternal's notmyfault to test this bug.
> 1. launch qemu use legacy bios mode. make sure qxl driver is active, then open notmyfault64.exe click on crash button. It will trigger a bsod
> 2. without reset/patch, we cannot see bluescreen shown
>
> before qxl revision 5, even DodResetDevice does nothing, the qemu will do reset after detect qxl mode mismatch. see https://github.com/qemu/qemu/blob/ed71c09ffd6fbd01c2a487d47291ae57b08671ea/hw/display/qxl.c#L1315
>
> But qxl revison 5+ requires explicit reset
>
> reference:
> not myfault: https://learn.microsoft.com/en-us/sysinternals/downloads/notmyfault
> DXGKDDI_RESET_DEVICE : https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/dispmprt/nc-dispmprt-dxgkddi_reset_device#remarks

Merged.

Now the question is about release and build.

Uri, Victor, should we pack a new release?

Regards,
  Frediano