[Spice-devel] [PATCH spice-common] build: Avoid Meson warning

[Frediano Ziglio]

Hi Uri,
   good catch.

Opened https://gitlab.freedesktop.org/spice/usbredir/-/merge_requests/71.

Frediano

Il giorno dom 5 nov 2023 alle ore 13:02 Uri Lublin
<ulublin at redhat.com> ha scritto:
>
> Hi Frediano,
>
> On Fri, Nov 3, 2023 at 10:59 AM Frediano Ziglio <freddy77 at gmail.com> wrote:
>>
>> Avoids:
>>
>> WARNING: You should add the boolean check kwarg to the run_command call.
>>          It currently defaults to false,
>>          but it will default to true in future releases of meson.
>>          See also: https://github.com/mesonbuild/meson/issues/9300
>>
>> Signed-off-by: Frediano Ziglio <freddy77 at gmail.com>
>
>
> Acked-by: Uri Lublin <uril at redhat.com>
>
> From a quick scan of the git repositories, there is a 'check' missing in usbredir too.
>
> Thanks,
>     Uri.
>
>
>>
>> ---
>>  meson.build | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 1018769..33f8f8a 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -132,7 +132,7 @@ if spice_common_generate_client_code or spice_common_generate_server_code
>>    if get_option('python-checks')
>>      foreach module : ['six', 'pyparsing']
>>        message('Checking for python module @0@'.format(module))
>> -      cmd = run_command(python, '-c', 'import @0@'.format(module))
>> +      cmd = run_command(python, '-c', 'import @0@'.format(module), check : false)
>>        if cmd.returncode() != 0
>>          error('Python module @0@ not found'.format(module))
>>        endif
>> --
>> 2.41.0
>>