[Spice-devel] 0.42: build fails

[Tomasz Kłoczko]

On Wed, 6 Sept 2023 at 18:15, Uri Lublin <ulublin at redhat.com> wrote:

> On Wed, Sep 6, 2023 at 11:17 AM Tomasz Kłoczko <kloczko.tomasz at gmail.com>
> wrote:
>
>> HI,
>>
>
> Hi,
>
> What distribution are you building this on ?
> Seems like there is a problem with the libcacard-devel package.
> Meson seems to find it but libcacard.so is not found by the gcc command.
>

MyOwn™️ 😋

Please ignore this email.
Issue already has been discussed, udentified and resoleved under
https://gitlab.freedesktop.org/spice/spice-gtk/-/issues/178
I found the issue with how the libcacard pkgconfig file is generated. Below
patch fixes issue.

``patch
--- a/meson.build
+++ b/meson.build
@@ -88,8 +88,7 @@
 )

 pc = import('pkgconfig')
-pc.generate(
-  libraries: libcacard,
   requires_private: ['glib-2.0'],
+pc.generate(libcacard,
   subdirs: 'cacard',
   version: meson.project_version(),
   name: 'cacard',
```
Missing "libcacard" as the first parameter is causing the "Libs:" line is
generated .pc file is not generated.

Additionally I just realised that case of interaction libcacard with
spice-gtk exposed again meson issue which I've reported in
https://github.com/mesonbuild/meson/issues/12225 however in this case looks
like meson developers do not understand difference between they assumptions
and fact that I've literally tested how pkgconfig is used by meson and rpm
on scaLE OF WHOLE DISTRIBUTION.

So second part of the solution is meson patch which removes generate and
propagate Requires.provate.
In this case my patch is not to submit as meson PR because distribution on
which I'm working is that NONE of the packages with libraries and pkgconfig
files packages without static libraries variants.

When I'll test that all packages which are using build dependencies defined
as "pkgcobfig(foo)" still everything is working will try to submit above
patch as libcacard  PR/

I'm expecting that above meson issue
inconsistently implementation Requires.private may cause some other issues
but it is possible to see on meson issue ticket discussion has been locked
so this is not a but "feature".🙁

kloczek
-- 
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH

>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20230906/846458d3/attachment.htm>