[Spice-devel] [PATCH 2/4] channel-display-gst: Add "byte-stream" as the stream format for h264

[Frediano Ziglio]

Il giorno ven 15 set 2023 alle ore 01:33 Vivek Kasireddy
<vivek.kasireddy at intel.com> ha scritto:
>
> Adding the string "stream-format=byte-stream" to decoder capabilities
> (dec_caps) for h264/h265 codecs stops Gstreamer from complaining
> about missing stream format.
>
> Cc: Frediano Ziglio <freddy77 at gmail.com>
> Cc: Dongwon Kim <dongwon.kim at intel.com>
> Cc: Jin Chung Teng <jin.chung.teng at intel.com>
> Cc: Hazwan Arif Mazlan <hazwan.arif.mazlan at intel.com>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy at intel.com>
> ---
>  src/channel-display-priv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/channel-display-priv.h b/src/channel-display-priv.h
> index 66c9cff..1a7590a 100644
> --- a/src/channel-display-priv.h
> +++ b/src/channel-display-priv.h
> @@ -177,7 +177,7 @@ static const struct {
>       * (hardcoded in spice-server), let's add it here to avoid the warning.
>       */
>      { SPICE_DISPLAY_CAP_CODEC_H264, "h264",
> -      "h264parse ! avdec_h264", "video/x-h264" },
> +      "h264parse ! avdec_h264", "video/x-h264,stream-format=byte-stream" },
>
>      /* SPICE_VIDEO_CODEC_TYPE_VP9 */
>      { SPICE_DISPLAY_CAP_CODEC_VP9, "vp9",
> @@ -185,7 +185,7 @@ static const struct {
>
>      /* SPICE_DISPLAY_CAP_CODEC_H265 */
>      { SPICE_DISPLAY_CAP_CODEC_H265, "h265",
> -      "h265parse ! avdec_h265", "video/x-h265" },
> +      "h265parse ! avdec_h265", "video/x-h265,stream-format=byte-stream" },
>
>  };
>

Hi,
   I agree with this change. Specifically I'm getting the warning too
even if my system is pretty updated.

This setting was removed by commit
https://gitlab.freedesktop.org/spice/spice-gtk/-/commit/c9129ed202b00f4a74ea7a55de19150194257e77
but the explanation about it was removed is not really clear to me.

Personally I think this commit should be applied in any case, it makes
sense independently of the series. Vivek, do you agree?

Victor, do you agree to this change?

Regards,
  Frediano