<html> <head> <meta http-equiv="content-type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Hi <div class="moz-cite-prefix">El 16/02/16 a las 15:23, Victor Toso escribió: </div> <blockquote cite="mid:20160216142350.GA6777@wingsuit.redhat.com" type="cite"> <pre wrap="">Hi Javier, On Tue, Feb 16, 2016 at 10:50:22AM +0100, Javier Celaya wrote: </pre> <blockquote type="cite"> <pre wrap="">El 15/02/16 a las 17:01, Javier Celaya escribió: </pre> <blockquote type="cite"> <pre wrap=""> El 15/02/16 a las 16:38, Victor Toso escribió: </pre> <blockquote type="cite"> <pre wrap="">Hi, On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote: </pre> <blockquote type="cite"> <pre wrap="">This patch set adds support for dynamic resolution changes with the WDDM driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld with some improvements: - It detects both the XDDM driver and the WDDM driver, and uses the correct API. - It detects if the client is trying to set the same resolution again, and does nothing. This is the result of the client detecting a primary surface destruction/construction when the resolution changes, and asking for a resolution change again. This bug does not happen with the XDDM driver, so it may be avoidable in some other way. - It uses an alternative method to update the list of display modes, that results in a nicer effect when changing the resolution. This method is compatible with the current driver implementation (v0.12), but for best results we have modified the driver to drop the previous method and to improve support of hardware pointers. The source can be found inhttps://github.com/flexvdi/qxl-dod, and precompiled and signed binaries can be downloaded fromhttp://depot.flexvdi.com/guest-tools/. </pre> </blockquote> <pre wrap="">You might be interested in taking a look at Sandy's work recently pushed to freedesktop at <a class="moz-txt-link-freetext" href="https://cgit.freedesktop.org/~teuf/qxl-wddm-dod/">https://cgit.freedesktop.org/~teuf/qxl-wddm-dod/</a> and thank you for your work on this, toso </pre> </blockquote> <pre wrap="">Thank you, Victor. I'll see if these patches are in sync with her job. </pre> </blockquote> <pre wrap="">It turns out they are not. In particular, she changed the interface to send a custom resolution to the driver. I'm going to try to coordinate with her, in case she also has a patch set for the vdagent, so do not push these patches upstream yet. Thanks for pointint this out. </pre> </blockquote> <pre wrap=""> Sure, you are welcome. Sadly, I don't think Sandy will be working on this anymore. At this moment I don't know anyone working on this. The work that she has done is the latest that I'm aware of regarding improving qxl-wddm-dod for windows 8+. I consider this a WIP and not yet maintained upstream... kind regards, toso </pre> </blockquote> I have not heard from Sandy yet. So, I suggest accepting these patches as they are now, since they work with the binary WDDM drivers issued by Red Hat to date. We will pick Sandy's work into our repository, as long as we do not break the current interface between vdagent and WDDM driver. Best <blockquote cite="mid:20160216142350.GA6777@wingsuit.redhat.com" type="cite"> <pre wrap=""> </pre> <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite"> <pre wrap="">Changes from v1: - New types and classes have been moved from common/vdcommon.h to vdagent/wddm.h, since they are actually not common to both the vdagent and the vdservice. The code for those classes is in vdagent/wddm.cpp. - Some improvements as suggested by Frediano Ziglio. Javier Celaya (2): Detect and use the new WDDM driver Use CCD API to update the WDDM display modes. Makefile.am | 2 + common/vdcommon.h | 4 + vdagent/desktop_layout.cpp | 69 ++++++++++++--- vdagent/wddm.cpp | 76 +++++++++++++++++ vdagent/wddm.h | 206 +++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 345 insertions(+), 12 deletions(-) create mode 100644 vdagent/wddm.cpp create mode 100644 vdagent/wddm.h -- 2.4.3 _______________________________________________ Spice-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/spice-devel">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a> </pre> </blockquote> </blockquote> <pre wrap=""> -- <a class="moz-txt-link-rfc2396E" href="http://flexvdi.com"><http://flexvdi.com></a><a class="moz-txt-link-rfc2396E" href="http://flexvdi.com"><http://flexvdi.com></a> Javier Celaya Software Engineer j <a class="moz-txt-link-rfc2396E" href="mailto:javier.celaya@flexvdi.com"><mailto:javier.celaya@flexvdi.com></a><a class="moz-txt-link-abbreviated" href="mailto:avier.celaya@flexvdi.com">avier.celaya@flexvdi.com</a> +34 876 60 00 73 @j_celaya </pre> </blockquote> <pre wrap=""> -- <a class="moz-txt-link-rfc2396E" href="http://flexvdi.com"><http://flexvdi.com></a><a class="moz-txt-link-rfc2396E" href="http://flexvdi.com"><http://flexvdi.com></a> Javier Celaya Software Engineer j <a class="moz-txt-link-rfc2396E" href="mailto:javier.celaya@flexvdi.com"><mailto:javier.celaya@flexvdi.com></a><a class="moz-txt-link-abbreviated" href="mailto:avier.celaya@flexvdi.com">avier.celaya@flexvdi.com</a> +34 876 60 00 73 @j_celaya </pre> </blockquote> </blockquote> <div class="moz-signature">-- <table style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px;" width="480" border="0" cellpadding="0" cellspacing="0"> <tbody> <tr> <td style=" vertical-align:top; padding-right:10;"> <a href="http://flexvdi.com"><img src="cid:part1.03020807.00010309@flexvdi.com" style="vertical-align: top;" height="45" width="151"></a><a href="http://flexvdi.com"> </a> Javier Celaya Software Engineer </td> <td style=" padding-left:18; padding-right:18; padding-top:7; padding-bottom:7;"> <img src="cid:part4.07010009.05070405@flexvdi.com" style="float: left;" height="17" width="17"> <a name="info"></a><a href="mailto:javier.celaya@flexvdi.com">j</a><a class="moz-txt-link-abbreviated" href="mailto:avier.celaya@flexvdi.com">avier.celaya@flexvdi.com</a> <img src="cid:part7.04030204.07090708@flexvdi.com" style="float: left;" height="17" width="17"> <a name="info"></a>+34 876 60 00 73 <img src="cid:part9.09020209.08000501@flexvdi.com" style="float: left;" height="17" width="17"> <a name="info"></a>@j_celaya </td> </tr> </tbody> </table> <table style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px;" border="0" cellpadding="0" cellspacing="2"> </table> </div> </body> </html>