<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 21 Feb 2016, at 12:33 PM, Dmitry Fleytman <<a href="mailto:dmitry@daynix.com" class="">dmitry@daynix.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 11 Feb 2016, at 01:30 AM, Jonathon Jongsma <<a href="mailto:jjongsma@redhat.com" class="">jjongsma@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">This breaks public API. I don't think we want to do that. We could deprecate it</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">somehow though.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div class=""><br class=""></div><div class="">Hi Jonathon,</div><div class=""><br class=""></div><div class="">How do we depreciate public functions? Is there are special procedure/macros for that? </div><div class="">I found SPICE_DEPRECATED macro. Should we just use it for this function?</div></div></div></div></blockquote><div><br class=""></div><div>So should I drop this patch or mark this function as deprecated somehow?</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Dmitry</div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Thu, 2015-10-29 at 17:27 +0200, Dmitry Fleytman wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">From: Dmitry Fleytman <<a href="mailto:dfleytma@redhat.com" class="">dfleytma@redhat.com</a>><br class=""><br class="">Synchronous disconnection is not a part of public interface anymore.<br class=""><br class="">Signed-off-by: Dmitry Fleytman <<a href="mailto:dfleytma@redhat.com" class="">dfleytma@redhat.com</a>><br class="">---<br class="">src/map-file | 1 -<br class="">src/usb-device-manager.c | 15 ++++++++-------<br class="">src/usb-device-manager.h | 3 ---<br class="">3 files changed, 8 insertions(+), 11 deletions(-)<br class=""><br class="">diff --git a/src/map-file b/src/map-file<br class="">index b9ba950..04442c8 100644<br class="">--- a/src/map-file<br class="">+++ b/src/map-file<br class="">@@ -126,7 +126,6 @@ spice_usb_device_get_type;<br class="">spice_usb_device_manager_can_redirect_device;<br class="">spice_usb_device_manager_connect_device_async;<br class="">spice_usb_device_manager_connect_device_finish;<br class="">-spice_usb_device_manager_disconnect_device;<br class="">spice_usb_device_manager_disconnect_device_async;<br class="">spice_usb_device_manager_is_redirecting;<br class="">spice_usb_device_manager_get;<br class="">diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c<br class="">index c697697..7cf04b7 100644<br class="">--- a/src/usb-device-manager.c<br class="">+++ b/src/usb-device-manager.c<br class="">@@ -214,6 +214,9 @@ void _connect_device_async_cb(GObject *gobject,<br class=""> GAsyncResult *channel_res,<br class=""> gpointer user_data);<br class=""><br class="">+static void<br class="">+_disconnect_device(SpiceUsbDeviceManager *self, SpiceUsbDevice *device);<br class="">+<br class="">G_DEFINE_BOXED_TYPE(SpiceUsbDevice, spice_usb_device,<br class=""> (GBoxedCopyFunc)spice_usb_device_ref,<br class=""> (GBoxedFreeFunc)spice_usb_device_unref)<br class="">@@ -992,7 +995,7 @@ static void<br class="">spice_usb_device_manager_remove_dev(SpiceUsbDeviceManager *self,<br class=""> }<br class="">#endif<br class=""><br class="">- spice_usb_device_manager_disconnect_device(self, device);<br class="">+ _disconnect_device(self, device);<br class=""><br class=""> SPICE_DEBUG("device removed %04x:%04x (%p)",<br class=""> spice_usb_device_get_vid(device),<br class="">@@ -1694,10 +1697,9 @@ void _connect_device_async_cb(GObject *gobject,<br class=""> g_simple_async_result_complete(result);<br class=""> g_object_unref(result);<br class="">}<br class="">-#endif<br class=""><br class="">/**<br class="">- * spice_usb_device_manager_disconnect_device:<br class="">+ * _disconnect_device:<br class=""> * @manager: the #SpiceUsbDeviceManager manager<br class=""> * @device: a #SpiceUsbDevice to disconnect<br class=""> *<br class="">@@ -1705,15 +1707,14 @@ void _connect_device_async_cb(GObject *gobject,<br class=""> *<br class=""> * Returns: %TRUE if @device has an associated USB redirection channel<br class=""> */<br class="">-void spice_usb_device_manager_disconnect_device(SpiceUsbDeviceManager *self,<br class="">- SpiceUsbDevice *device)<br class="">+static void<br class="">+_disconnect_device(SpiceUsbDeviceManager *self, SpiceUsbDevice *device)<br class="">{<br class=""> g_return_if_fail(SPICE_IS_USB_DEVICE_MANAGER(self));<br class=""> g_return_if_fail(device != NULL);<br class=""><br class=""> SPICE_DEBUG("disconnecting device %p", device);<br class=""><br class="">-#ifdef USE_USBREDIR<br class=""> SpiceUsbredirChannel *channel;<br class=""><br class=""> channel = spice_usb_device_manager_get_channel_for_dev(self, device);<br class="">@@ -1724,9 +1725,9 @@ void<br class="">spice_usb_device_manager_disconnect_device(SpiceUsbDeviceManager *self,<br class=""> if(self->priv->use_usbclerk)<br class=""> _spice_usb_device_manager_uninstall_driver_async(self, device);<br class="">#endif<br class="">+}<br class=""><br class="">#endif<br class="">-}<br class=""><br class="">typedef struct _disconnect_cb_data<br class="">{<br class="">diff --git a/src/usb-device-manager.h b/src/usb-device-manager.h<br class="">index 814af2e..978f4a0 100644<br class="">--- a/src/usb-device-manager.h<br class="">+++ b/src/usb-device-manager.h<br class="">@@ -127,9 +127,6 @@ void spice_usb_device_manager_disconnect_device_async(<br class="">gboolean spice_usb_device_manager_connect_device_finish(<br class=""> SpiceUsbDeviceManager *self, GAsyncResult *res, GError **err);<br class=""><br class="">-void spice_usb_device_manager_disconnect_device(SpiceUsbDeviceManager<br class="">*manager,<br class="">- SpiceUsbDevice *device);<br class="">-<br class="">gboolean<br class="">spice_usb_device_manager_can_redirect_device(SpiceUsbDeviceManager *self,<br class=""> SpiceUsbDevice *device,<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Reviewed-by: Jonathon Jongsma <</span><a href="mailto:jjongsma@redhat.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">jjongsma@redhat.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">></span></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></body></html>