<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Can someone review this patch, please?<br>
Thank you<br>
<br>
<div class="moz-cite-prefix">El 13/04/16 a las 13:42, Javier Celaya
escribió:<br>
</div>
<blockquote
cite="mid:1460547742-4262-1-git-send-email-javier.celaya@flexvdi.com"
type="cite">
<pre wrap="">With scaling enabled, the size request of the widget must be 640x480
(the same as with resize_guest_enable) so that the widget can be
actually scalled down.
---
src/spice-widget.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 6f638fb..f445f3f 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -169,23 +169,12 @@ static void spice_display_get_property(GObject *object,
}
}
-static void scaling_updated(SpiceDisplay *display)
-{
- SpiceDisplayPrivate *d = display->priv;
- GdkWindow *window = gtk_widget_get_window(GTK_WIDGET(display));
-
- recalc_geometry(GTK_WIDGET(display));
- if (d->ximage && window) { /* if not yet shown */
- gtk_widget_queue_draw(GTK_WIDGET(display));
- }
-}
-
static void update_size_request(SpiceDisplay *display)
{
SpiceDisplayPrivate *d = display->priv;
gint reqwidth, reqheight;
- if (d->resize_guest_enable) {
+ if (d->resize_guest_enable || d->allow_scaling) {
reqwidth = 640;
reqheight = 480;
} else {
@@ -197,6 +186,18 @@ static void update_size_request(SpiceDisplay *display)
recalc_geometry(GTK_WIDGET(display));
}
+static void scaling_updated(SpiceDisplay *display)
+{
+ SpiceDisplayPrivate *d = display->priv;
+ GdkWindow *window = gtk_widget_get_window(GTK_WIDGET(display));
+
+ recalc_geometry(GTK_WIDGET(display));
+ if (d->ximage && window) { /* if not yet shown */
+ gtk_widget_queue_draw(GTK_WIDGET(display));
+ }
+ update_size_request(display);
+}
+
static void update_keyboard_focus(SpiceDisplay *display, gboolean state)
{
SpiceDisplayPrivate *d = display->priv;
</pre>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"><br>
<br>
</p>
<table style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px;" width="480" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<td style=" vertical-align:top; padding-right:10;">
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><a
href="http://flexvdi.com"><img
src="cid:part1.03050708.06050100@flexvdi.com"
style="vertical-align: top;" height="45" width="151"></a><a
href="http://flexvdi.com"><span style="
font-family:'Lato,Arial'; text-decoration:
underline; color:#0057ae;"> </span></a></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><span style="
font-family:'Lato,Arial'; font-size:15px;
font-weight:600; color:#3e5d6b;">Javier Celaya </span></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><span style="
font-family:'Lato,Arial'; font-size:13px;
font-style:italic; color:#00a1c1;">Software Engineer </span></p>
</td>
<td style=" padding-left:18; padding-right:18;
padding-top:7; padding-bottom:7;">
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><img
src="cid:part4.05040202.03090703@flexvdi.com"
style="float: left;" height="17" width="17"><span
style=" font-family:'Lato,Arial';"> </span><a
name="info"></a><a
href="mailto:javier.celaya@flexvdi.com"><span style="
font-family:'Lato,Arial'; font-size:14px;
text-decoration: underline; color:#727272;">j</span></a><span
style=" font-family:'Lato,Arial'; font-size:14px;
text-decoration: underline; color:#727272;"><a class="moz-txt-link-abbreviated" href="mailto:avier.celaya@flexvdi.com">avier.celaya@flexvdi.com</a></span><span
style=" font-family:'Lato,Arial';"> </span></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><img
src="cid:part7.06050901.03070707@flexvdi.com"
style="float: left;" height="17" width="17"><span
style=" font-family:'Lato,Arial';"> </span><a
name="info"></a><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">+</span><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">34 876 60 00 73</span></p>
<p style=" margin-top:0px; margin-bottom:0px;
margin-left:0px; margin-right:0px; -qt-block-indent:0;
text-indent:0px; -qt-user-state:0;"><img
src="cid:part9.03000202.06090409@flexvdi.com"
style="float: left;" height="17" width="17"><span
style=" font-family:'Lato,Arial';"> </span><a
name="info"></a><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">@</span><span style="
font-family:'Lato,Arial'; font-size:14px;
color:#727272;">j_celaya</span><span style="
font-family:'Lato,Arial';"> </span></p>
</td>
</tr>
</tbody>
</table>
<table style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px;" border="0" cellpadding="0" cellspacing="2">
</table>
</div>
</body>
</html>