<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 3 Aug 2016, at 16:20 PM, Christophe Fergeau <<a href="mailto:cfergeau@redhat.com" class="">cfergeau@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Wed, Aug 03, 2016 at 03:04:23PM +0200, Christophe Fergeau wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">On Wed, Aug 03, 2016 at 03:53:27PM +0300, Dmitry Fleytman wrote:<br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">On 3 Aug 2016, at 13:38 PM, Sameeh Jubran <<a href="mailto:sameeh@daynix.com" class="">sameeh@daynix.com</a>> wrote:<br class=""><br class=""><br class=""><br class="">On Wed, Aug 3, 2016 at 1:19 PM, Christophe Fergeau <<a href="mailto:cfergeau@redhat.com" class="">cfergeau@redhat.com</a> <<a href="mailto:cfergeau@redhat.com" class="">mailto:cfergeau@redhat.com</a>>> wrote:<br class="">On Wed, Aug 03, 2016 at 05:25:59AM -0400, Frediano Ziglio wrote:<br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">Can you please further explain regarding the licensing? which license should<br class="">be used?<br class=""></blockquote><br class="">These defines came from Microsoft headers or from the web like<br class=""><a href="https://msdn.microsoft.com/en-us/library/windows/hardware/ff548113(v=vs.85).aspx" class="">https://msdn.microsoft.com/en-us/library/windows/hardware/ff548113(v=vs.85).aspx</a> <<a href="https://msdn.microsoft.com/en-us/library/windows/hardware/ff548113(v=vs.85).aspx" class="">https://msdn.microsoft.com/en-us/library/windows/hardware/ff548113(v=vs.85).aspx</a>><br class="">simply you can't copy from header (which have its license) and/or from web<br class="">(see <a href="https://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default.aspx" class="">https://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default.aspx</a> <<a href="https://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default.aspx" class="">https://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default.aspx</a>> )<br class=""><br class="">Not sure about the license. Looks like Mingw headers have public domain licensing.<br class="">For instance <a href="https://searchcode.com/codesearch/raw/11987244/" class="">https://searchcode.com/codesearch/raw/11987244/</a> <<a href="https://searchcode.com/codesearch/raw/11987244/" class="">https://searchcode.com/codesearch/raw/11987244/</a>> have a Microsoft disclaimer.<br class=""><br class="">Maybe I'm too overcautious<br class=""></blockquote><br class="">I don't think you are being too caution, either these definitions have<br class="">an explicit licence compatible with the vdagent-win one, or we should<br class="">not copy them this way. Why do we need to copy these definitions in<br class="">vdagent-win in the first place?<br class=""><br class="">These definitions and structures are used in the CCD api and provided by windows,<br class="">However they are absent in mingw. What are our options now?<br class=""><br class="">Please note that we eliminated many of the unnecessary and unused definitions from the ones we<br class="">previously included in our previous patch ( <a href="https://lists.freedesktop.org/archives/spice-devel/2016-July/030796.html" class="">https://lists.freedesktop.org/archives/spice-devel/2016-July/030796.html</a> <<a href="https://lists.freedesktop.org/archives/spice-devel/2016-July/030796.html" class="">https://lists.freedesktop.org/archives/spice-devel/2016-July/030796.html</a>> ). Moreover<br class="">they are now present in the cpp files.<br class=""></blockquote><br class="">We dropped most of definitions from Sandy’s series and left only those<br class="">we really need, so there are no copy-pasted files anymore, but we cannot avoid<br class="">using them at all because they are absent in MinGW.<br class=""><br class="">Christophe, Frediano, do you have any idea what to do in this case?<br class=""></blockquote><br class="">If they are only needed for mingw builds, I'd start with splitting this<br class="">in their own "Fix mingw build" patch, with an explanation why we<br class="">duplicated header content, where the content is coming from (ie why we<br class="">are allowed to license it the way we do), and so on.<br class=""><br class="">If we don't have find appropriately licensed headers covering what we<br class="">need, then we may have to decide that CCD support is vc++ only.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="https://github.com/wine-mirror/wine/blob/master/include/wingdi.h" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">https://github.com/wine-mirror/wine/blob/master/include/wingdi.h</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><span class="Apple-converted-space"> </span>is</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">LGPLv2.1 and seems to have some of the definitions we need (I did not</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">check all of them). I don't know if it can be used directly with mingw</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">and if it's a drop-in replacement for the corresponding MS header.</span></div></blockquote><div><br class=""></div><div>Great! It contains declarations we need. We will take from there.</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Christophe</span></div></blockquote></div><br class=""></body></html>