<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div>The code is fine but the rationale lacks a bit.<br></div><div>On Linux there is no such feature but not the bug so if your rationale is this is needed to fix a bug I don't understand why.<br></div><div>Also the rationale assume the server or client pointer is all dependent on vdagent existence which seems not true.<br></div><div>I was looking at Sandy (should download last WDDM) code and seems that EnablePointer is used in 3 cases<br></div><div>- to reply cursor support (which is wrong, driver support cursor either way);<br></div><div>- to avoid sending cursor shape changes (which seems not that fine);<br></div><div>- to avoid sending cursor movements (which reduces guest -> server dialog for sure and perhaps server -> client if server propagate always).<br></div><div><br></div><div>Frediano<br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><br></div><div dir="ltr">Hi,<div><br></div><div>What do you think that needs to be done?</div><div>The patches should be applied?</div><div>The interface of the device should be extended to support broadcasting the mouse mode to the driver? ( I think would require to modify the spice protocol )</div><div>The interface of spice-gtk should be extended to support broadcasting the mouse mode to vdagent?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 8, 2016 at 8:08 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:times new roman,new york,times,serif;font-size:12pt;color:#000000"><span class=""><div><br></div><blockquote style="border-left:2px solid #1010ff;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Aug 8, 2016 at 6:47 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>> An optimal solution to this would be that the driver knows somehow when<br>
> we are in a server mode and when we are in a client mode. However this<br>
> information isn't available in the driver nor in the vdagent.<br>
<br>
</span>Could you explain why an optimal solution require this knowledge?<br>
Also "However this information isn't available in the driver nor in the vdagent."<br>
does not make sense to me. The vdagent is sending this information to the<br>
driver so this information is available in vdagent.<br></blockquote><div>The current information the driver is getting is about Vdagent state (running/off), When</div><div>Vdagent is running then the client mouse should be enabled and when Vdagent is off</div><div>server mouse should be enabled. This is true for the typical use case of Vdagent.</div><div>But this isn't exactly true all of the time, for example when running Spicy along with Vdagent on</div><div> and we send a command to change the mouse mode to server mode we get that Vdagent state is on</div><div>and the mouse in server mode.</div></div></div></div></blockquote></span><div>Now I got it.<br></div><div><br></div><div>So currently the driver bases it's behavior on vdagent existence but this is not correct<br></div><div>as there are cases where agent is present but you want to used server mouse.<br></div><div><br></div><div>Looking at the rationale:<br></div><span class=""><div><br></div><div>"A new ioctl for updating the driver with vdagent running state.<br>This patch adds new ioctl operation to Vdagent in order to update<br>the driver on Vdagent state. This allows the driver to know<br>when Vdagent is running and when it is off.<br><div><br></div>Spice supports two mouse modes: server and client. The server mouse<br>mode pointer should be enabled when vdagent is off and the client<br>mouse mode should be enabled when it is on. The mouse mode<br>is updated by the driver and thus this patch is needed."</div><div><br></div></span><div>I still have a doubt. Is not the service (vdagentd in Linux) that speak</div><div>to the driver? Potentially there are multiple agents, one for login.<br></div><div><br></div><div>Also if you can tell client to use server mode in this case you<br></div><div>end up having the agent running but server mode which<br></div><div>seems wrong from your rationale.<br></div><div><br></div><div>Also "adds new ioctl operation to Vdagent" the ioctl is implemented<br></div><div>in the driver so I would say "adds new ioctl operation to the driver in<br></div><div>order to allow Vdagent to communicate its state to the driver".<span class="HOEnZb"><span style="color: #888888;" data-mce-style="color: #888888;" color="#888888"><br></span></span></div><span class="HOEnZb"><span style="color: #888888;" data-mce-style="color: #888888;" color="#888888"><div><br></div><div>Frediano<br></div></span></span><div><div class="h5"><div><br></div><blockquote style="border-left:2px solid #1010ff;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Frediano<br><span><br>
> On Mon, Aug 8, 2016 at 6:33 PM, Christophe Fergeau < <a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a> ><br>
> wrote:<br>
<br>
> > On Mon, Aug 08, 2016 at 06:19:41PM +0300, Sameeh Jubran wrote:<br>
><br>
> > > ><br>
><br>
> > > This patch enables the driver to send move commands to the QXL device<br>
> > > when<br>
><br>
> > > vdagent is off.<br>
><br>
> > > This maybe the reason you are not getting any move commands.<br>
><br>
<br>
> > But don't we have exactly the same issue with a fedora guest or a win7-<br>
><br>
> > guest? I've observed the same with a Fedora guest at least.<br>
><br>
> > Also I don't think there is a strict equivalence between vdagent is<br>
><br>
> > running and mouse is in server mode, so if we were to change this at the<br>
><br>
> > agent level, are we going to fix all cases?<br>
><br>
<br>
> > Christophe<br>
><br>
<br>
> --<br>
> Respectfully,<br>
> Sameeh Jubran<br>
> Linkedin<br>
> Junior Software Engineer @ Daynix .<br>
<br>
</span>> _______________________________________________<br>
> Spice-devel mailing list<br>
> <a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span style="color:#0b5394;font-family:times new roman,serif;font-size:large">Respectfully,<br></span><div style="font-size:12.8px;color:rgb(136,136,136)"><span style="color:#0b5394;font-family:times new roman,serif;font-size:large"><b><i>Sameeh Jubran</i></b></span></div><div style="font-size:12.8px;color:rgb(136,136,136)"><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large"><span style="line-height:15px"><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="m_6910339767400352337_m_3526982272278625377_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank">Linkedin</a></span></i><br></div><div style="font-size:12.8px;color:rgb(136,136,136)"><span style="color:#073763;font-family:times new roman,serif;font-size:large"><i>Junior Software Engineer @ <a href="http://www.daynix.com" target="_blank">Daynix</a>.</i></span></div></div></div></div></div></div></div></div></div></blockquote><div><br></div></div></div></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" color="#0b5394" face="times new roman, serif" size="4">Respectfully,<br></span><div style="font-size:12.8px;color:rgb(136,136,136)"><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" color="#0b5394" face="times new roman, serif" size="4"><b><i>Sameeh Jubran</i></b></span></div><div style="font-size:12.8px;color:rgb(136,136,136)"><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large"><span style="line-height:15px"><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank">Linkedin</a></span></i><br></div><div style="font-size:12.8px;color:rgb(136,136,136)"><span style="color: #073763; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #073763; font-family: times new roman,serif; font-size: large;" color="#073763" face="times new roman, serif" size="4"><i>Junior Software Engineer @ <a href="http://www.daynix.com" target="_blank">Daynix</a>.</i></span></div></div></div></div></div></div></div>
</div>
</blockquote><div><br></div></div></body></html>