<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Frediano,<div class=""><br class=""></div><div class="">Thanks for your review!</div><div class="">This path is based on assumption that mouse mode is always client for as long as vdagent running.</div><div class="">As we know now this assumption is wrong, so we are calling this patch back for rework. </div><div class=""><br class=""></div><div class="">Regards,</div><div class="">Dmitry</div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On 9 Aug 2016, at 19:42 PM, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><div class="">The code is fine but the rationale lacks a bit.<br class=""></div><div class="">On Linux there is no such feature but not the bug so if your rationale is this is needed to fix a bug I don't understand why.<br class=""></div><div class="">Also the rationale assume the server or client pointer is all dependent on vdagent existence which seems not true.<br class=""></div><div class="">I was looking at Sandy (should download last WDDM) code and seems that EnablePointer is used in 3 cases<br class=""></div><div class="">- to reply cursor support (which is wrong, driver support cursor either way);<br class=""></div><div class="">- to avoid sending cursor shape changes (which seems not that fine);<br class=""></div><div class="">- to avoid sending cursor movements (which reduces guest -> server dialog for sure and perhaps server -> client if server propagate always).<br class=""></div><div class=""><br class=""></div><div class="">Frediano<br class=""></div><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div class=""><br class=""></div><div dir="ltr" class="">Hi,<div class=""><br class=""></div><div class="">What do you think that needs to be done?</div><div class="">The patches should be applied?</div><div class="">The interface of the device should be extended to support broadcasting the mouse mode to the driver? ( I think would require to modify the spice protocol )</div><div class="">The interface of spice-gtk should be extended to support broadcasting the mouse mode to vdagent?</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Aug 8, 2016 at 8:08 PM, Frediano Ziglio <span dir="ltr" class=""><<a href="mailto:fziglio@redhat.com" target="_blank" class="">fziglio@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><span class=""><div class=""><br class=""></div><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Mon, Aug 8, 2016 at 6:47 PM, Frediano Ziglio <span dir="ltr" class=""><<a href="mailto:fziglio@redhat.com" target="_blank" class="">fziglio@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> An optimal solution to this would be that the driver knows somehow when<br class="">
> we are in a server mode and when we are in a client mode. However this<br class="">
> information isn't available in the driver nor in the vdagent.<br class="">
<br class="">
</span>Could you explain why an optimal solution require this knowledge?<br class="">
Also "However this information isn't available in the driver nor in the vdagent."<br class="">
does not make sense to me. The vdagent is sending this information to the<br class="">
driver so this information is available in vdagent.<br class=""></blockquote><div class="">The current information the driver is getting is about Vdagent state (running/off), When</div><div class="">Vdagent is running then the client mouse should be enabled and when Vdagent is off</div><div class="">server mouse should be enabled. This is true for the typical use case of Vdagent.</div><div class="">But this isn't exactly true all of the time, for example when running Spicy along with Vdagent on</div><div class=""> and we send a command to change the mouse mode to server mode we get that Vdagent state is on</div><div class="">and the mouse in server mode.</div></div></div></div></blockquote></span><div class="">Now I got it.<br class=""></div><div class=""><br class=""></div><div class="">So currently the driver bases it's behavior on vdagent existence but this is not correct<br class=""></div><div class="">as there are cases where agent is present but you want to used server mouse.<br class=""></div><div class=""><br class=""></div><div class="">Looking at the rationale:<br class=""></div><span class=""><div class=""><br class=""></div><div class="">"A new ioctl for updating the driver with vdagent running state.<br class="">This patch adds new ioctl operation to Vdagent in order to update<br class="">the driver on Vdagent state. This allows the driver to know<br class="">when Vdagent is running and when it is off.<br class=""><div class=""><br class=""></div>Spice supports two mouse modes: server and client. The server mouse<br class="">mode pointer should be enabled when vdagent is off and the client<br class="">mouse mode should be enabled when it is on. The mouse mode<br class="">is updated by the driver and thus this patch is needed."</div><div class=""><br class=""></div></span><div class="">I still have a doubt. Is not the service (vdagentd in Linux) that speak</div><div class="">to the driver? Potentially there are multiple agents, one for login.<br class=""></div><div class=""><br class=""></div><div class="">Also if you can tell client to use server mode in this case you<br class=""></div><div class="">end up having the agent running but server mode which<br class=""></div><div class="">seems wrong from your rationale.<br class=""></div><div class=""><br class=""></div><div class="">Also "adds new ioctl operation to Vdagent" the ioctl is implemented<br class=""></div><div class="">in the driver so I would say "adds new ioctl operation to the driver in<br class=""></div><div class="">order to allow Vdagent to communicate its state to the driver".<span class="HOEnZb"><span style="color: #888888;" data-mce-style="color: #888888;" class=""><br class=""></span></span></div><span class="HOEnZb"><span style="color: #888888;" data-mce-style="color: #888888;" class=""><div class=""><br class=""></div><div class="">Frediano<br class=""></div></span></span><div class=""><div class="h5"><div class=""><br class=""></div><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="">
Frediano<br class=""><span class=""><br class="">
> On Mon, Aug 8, 2016 at 6:33 PM, Christophe Fergeau < <a href="mailto:cfergeau@redhat.com" target="_blank" class="">cfergeau@redhat.com</a> ><br class="">
> wrote:<br class="">
<br class="">
> > On Mon, Aug 08, 2016 at 06:19:41PM +0300, Sameeh Jubran wrote:<br class="">
><br class="">
> > > ><br class="">
><br class="">
> > > This patch enables the driver to send move commands to the QXL device<br class="">
> > > when<br class="">
><br class="">
> > > vdagent is off.<br class="">
><br class="">
> > > This maybe the reason you are not getting any move commands.<br class="">
><br class="">
<br class="">
> > But don't we have exactly the same issue with a fedora guest or a win7-<br class="">
><br class="">
> > guest? I've observed the same with a Fedora guest at least.<br class="">
><br class="">
> > Also I don't think there is a strict equivalence between vdagent is<br class="">
><br class="">
> > running and mouse is in server mode, so if we were to change this at the<br class="">
><br class="">
> > agent level, are we going to fix all cases?<br class="">
><br class="">
<br class="">
> > Christophe<br class="">
><br class="">
<br class="">
> --<br class="">
> Respectfully,<br class="">
> Sameeh Jubran<br class="">
> Linkedin<br class="">
> Junior Software Engineer @ Daynix .<br class="">
<br class="">
</span>> _______________________________________________<br class="">
> Spice-devel mailing list<br class="">
> <a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank" class="">Spice-devel@lists.freedesktop.org</a><br class="">
> <a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank" class="">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br class=""></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><span style="color:#0b5394;font-family:times new roman,serif;font-size:large" class="">Respectfully,<br class=""></span><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color:#0b5394;font-family:times new roman,serif;font-size:large" class=""><b class=""><i class="">Sameeh Jubran</i></b></span></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large" class=""><span style="line-height:15px" class=""><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="m_6910339767400352337_m_3526982272278625377_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank" class="">Linkedin</a></span></i><br class=""></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color:#073763;font-family:times new roman,serif;font-size:large" class=""><i class="">Junior Software Engineer @ <a href="http://www.daynix.com/" target="_blank" class="">Daynix</a>.</i></span></div></div></div></div></div></div></div></div></div></blockquote><div class=""><br class=""></div></div></div></div></div></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class="">Respectfully,<br class=""></span><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class=""><b class=""><i class="">Sameeh Jubran</i></b></span></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large" class=""><span style="line-height:15px" class=""><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank" class="">Linkedin</a></span></i><br class=""></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color: #073763; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #073763; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class=""><i class="">Junior Software Engineer @ <a href="http://www.daynix.com/" target="_blank" class="">Daynix</a>.</i></span></div></div></div></div></div></div></div>
</div>
</blockquote><div class=""><br class=""></div></div></div>_______________________________________________<br class="">Spice-devel mailing list<br class=""><a href="mailto:Spice-devel@lists.freedesktop.org" class="">Spice-devel@lists.freedesktop.org</a><br class="">https://lists.freedesktop.org/mailman/listinfo/spice-devel<br class=""></div></blockquote></div><br class=""></div></body></html>