<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 16, 2016 at 1:27 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">><br>
> This patch defines the structures of ioctls that are used between<br>
> win-vdagent and the qxl-wddm-dod driver.<br>
><br>
> Signed-off-by: Sameeh Jubran <<a href="mailto:sameeh@daynix.com">sameeh@daynix.com</a>><br>
> ---<br>
>  spice/qxl_windows.h | 16 ++++++++++++----<br>
>  1 file changed, 12 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h<br>
> index bc2ceff..c4776d4 100644<br>
> --- a/spice/qxl_windows.h<br>
> +++ b/spice/qxl_windows.h<br>
> @@ -2,20 +2,28 @@<br>
>  #define _H_QXL_WINDOWS<br>
><br>
>  #include <spice/types.h><br>
> -<br>
> +#include <spice/qxl_dev.h><br>
>  #include <spice/start-packed.h><br>
><br>
>  enum {<br>
>      QXL_ESCAPE_SET_CUSTOM_DISPLAY = 0x10001,<br>
> -    QXL_ESCAPE_MONITOR_CONFIG<br>
> +    QXL_ESCAPE_MONITOR_CONFIG,<br>
> +    QXL_ESCAPE_VDAGENT_RUNNING<br>
<br>
</span>Didn't we decide to remove this?<br></blockquote><div>We can't remove this unless there is a good working alternative. We use those</div><div>enums when calling this function <a href="https://msdn.microsoft.com/en-us/library/windows/desktop/dd162708%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396">https://msdn.microsoft.com/en-us/library/windows/desktop/dd162708%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396</a></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class=""><br>
>  };<br>
><br>
> -typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {<br>
> +struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {<br>
>      uint32_t xres;<br>
>      uint32_t yres;<br>
>      uint32_t bpp;<br>
> -} QXLEscapeSetCustomDisplay;<br>
> +};<br>
<br>
</span>API change here.<br></blockquote><div>why? only removed unneeded typedef. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class=""><div class="h5"><br>
><br>
> +struct SPICE_ATTR_PACKED QXL_ESCAPE {<br>
> +    uint32_t ioctl;<br>
> +    union {<br>
> +        QXLEscapeSetCustomDisplay custom_display;<br>
> +        QXLHead monitor_config;<br>
> +    };<br>
> +};<br>
>  #include <spice/end-packed.h><br>
><br>
>  #endif /* _H_QXL_WINDOWS */<br>
<br>
</div></div><span class=""><font color="#888888">Frediano<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="4" color="#0b5394" face="times new roman, serif">Respectfully,<br></font><div style="font-size:12.8px;color:rgb(136,136,136)"><font size="4" color="#0b5394" face="times new roman, serif"><b><i>Sameeh Jubran</i></b></font></div><div style="font-size:12.8px;color:rgb(136,136,136)"><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large"><span style="line-height:15px"><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank">Linkedin</a></span></i><br></div><div style="font-size:12.8px;color:rgb(136,136,136)"><font size="4" face="times new roman, serif" color="#073763"><i>Junior Software Engineer @ <a href="http://www.daynix.com" target="_blank">Daynix</a>.</i></font></div></div></div></div></div></div></div>
</div></div>