<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 16, 2016 at 1:27 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">><br> > This patch defines the structures of ioctls that are used between<br> > win-vdagent and the qxl-wddm-dod driver.<br> ><br> > Signed-off-by: Sameeh Jubran <<a href="mailto:sameeh@daynix.com" target="_blank">sameeh@daynix.com</a>><br> > ---<br> > spice/qxl_windows.h | 16 ++++++++++++----<br> > 1 file changed, 12 insertions(+), 4 deletions(-)<br> ><br> > diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h<br> > index bc2ceff..c4776d4 100644<br> > --- a/spice/qxl_windows.h<br> > +++ b/spice/qxl_windows.h<br> > @@ -2,20 +2,28 @@<br> > #define _H_QXL_WINDOWS<br> ><br> > #include <spice/types.h><br> > -<br> > +#include <spice/qxl_dev.h><br> > #include <spice/start-packed.h><br> ><br> > enum {<br> > QXL_ESCAPE_SET_CUSTOM_DISPLAY = 0x10001,<br> > - QXL_ESCAPE_MONITOR_CONFIG<br> > + QXL_ESCAPE_MONITOR_CONFIG,<br> > + QXL_ESCAPE_VDAGENT_RUNNING<br> <br> </span>Didn't we decide to remove this?<br></blockquote><div>We can't remove this unless there is a good working alternative. We use those</div><div>enums when calling this function <a href="https://msdn.microsoft.com/en-us/library/windows/desktop/dd162708%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396" target="_blank">https://msdn.microsoft.com/en-us/library/windows/desktop/dd162708%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396</a><br data-mce-bogus="1"></div></div></div></div></blockquote><div><br></div><div>Was referring to <span>QXL_ESCAPE_VDAGENT_RUNNING</span>, you are currently not using it and<br></div><div>also you are not defining a structure for it. I think it's just some lines changes that do not<br></div><div>own to this change.<br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class=""><br> > };<br> ><br> > -typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {<br> > +struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {<br> > uint32_t xres;<br> > uint32_t yres;<br> > uint32_t bpp;<br> > -} QXLEscapeSetCustomDisplay;<br> > +};<br> <br> </span>API change here.<br></blockquote><div>why? only removed unneeded typedef. </div></div></div></div></blockquote><div><br>Yes, but this break C API, actually this would make this header not C compatible.<br></div><div>This as using QXLEscapeSetCustomDisplay without struct (like in following line)</div><div>would cause an error.<br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5"><br> ><br> > +struct SPICE_ATTR_PACKED QXL_ESCAPE {</div></div></blockquote></div></div></div></blockquote><div><br></div><div>I would use QXLEscape instead, all structures/enums use this kind of naming.<br></div><div>Would stick to typedefs too.<br></div><div><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5"><br> > + uint32_t ioctl;<br> > + union {<br> > + QXLEscapeSetCustomDisplay custom_display;<br> > + QXLHead monitor_config;<br> > + };<br> > +};<br> > #include <spice/end-packed.h><br> ><br> > #endif /* _H_QXL_WINDOWS */<br></div></div></blockquote></div></div></div></blockquote><div>Frediano<br></div><div><br></div></div></body></html>