<div dir="ltr">Hi<br><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 30, 2016 at 3:24 PM Christophe Fergeau <<a href="mailto:cfergeau@redhat.com">cfergeau@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Another option would be to ship pkg.m4 from pkg-config 0.29 in<br>
spice-gtk/m4/, though I don't understand how AC_SUBST was made unneeded,<br>
so maybe that's not enough (?)<br></blockquote><div><br></div><div>m4 should be enough, however it seems that AC_SUBST of _CFLAGS & _LIBS  has been there forever. But it was changed in <a href="https://cgit.freedesktop.org/pkg-config/commit/?id=b1584b5aaf9ce396e61599caff2b5e15f01daf91">https://cgit.freedesktop.org/pkg-config/commit/?id=b1584b5aaf9ce396e61599caff2b5e15f01daf91</a><br><br></div><div>Now I don't get what autofoo magic put them in the subst list, but it works.<br><br></div><div>My comment was based on <a href="https://autotools.io/pkgconfig/pkg_check_modules.html">https://autotools.io/pkgconfig/pkg_check_modules.html</a> doc, which is usually a solid reference, but here I don't know what backs the 0.24...<br></div><div><br></div><div>So, I think we could simply remove the prereq.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Christophe<br>
<br>
On Tue, Aug 30, 2016 at 12:52:43PM +0200, Christophe Fergeau wrote:<br>
> On Fri, Aug 19, 2016 at 09:35:09PM +0400, <a href="mailto:marcandre.lureau@redhat.com" target="_blank">marcandre.lureau@redhat.com</a> wrote:<br>
> > From: Marc-André Lureau <<a href="mailto:marcandre.lureau@redhat.com" target="_blank">marcandre.lureau@redhat.com</a>><br>
> ><br>
> > So we can drop the AC_SUBST for _CFLAGS & _LIBS variable (since 0.24<br>
> > but there is no clean way to check that before PKG_PREREQ in 0.29,<br>
> > released last year)<br>
> ><br>
> > Signed-off-by: Marc-André Lureau <<a href="mailto:marcandre.lureau@redhat.com" target="_blank">marcandre.lureau@redhat.com</a>><br>
> > ---<br>
> >  <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 26 ++++----------------------<br>
> >  1 file changed, 4 insertions(+), 22 deletions(-)<br>
> ><br>
> > diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
> > index 9b2351d..1e27202 100644<br>
> > --- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
> > +++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
> > @@ -12,6 +12,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 -Wall -Werror -Wno-portability])<br>
> >  m4_ifdef([AM_PROG_AR], [AM_PROG_AR])<br>
> >  LT_INIT([disable-static win32-dll])<br>
> >  AM_MAINTAINER_MODE<br>
> > +m4_ifndef([PKG_PREREQ],<br>
> > +        [m4_fatal([must install pkg-config 0.29 or later before running autoconf/autogen])])<br>
><br>
> NACK to that bit, as Victor's testing showed, it's not that widespread<br>
> yet. Maybe something PKG_PREREQ-like can be built using $(pkg-config<br>
> --version) and m4_version_compare(), alternatively, we could just assume 0.24 is always present.<br>
> Or just revert this patch.<br>
><br>
> Christophe<br>
<br>
<br>
_______________________________________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
</blockquote></div></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Marc-André Lureau<br></div></div>