<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div>As it's used only by the driver I would prefer defined just in the driver.<br></div><div><br></div><div>Frediano<br></div><div><br></div><div><br></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>From: </b>"Sameeh Jubran" <sameeh@daynix.com><br><b>To: </b>"Frediano Ziglio" <fziglio@redhat.com><br><b>Cc: </b>"Spice List" <spice-devel@lists.freedesktop.org>, "Dmitry Fleytman" <dmitry@daynix.com><br><b>Sent: </b>Thursday, September 1, 2016 12:58:26 PM<br><b>Subject: </b>Re: [PATCH v5] Add ioctls structures to qxl_windows.h<br><div><br></div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 1, 2016 at 2:50 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>><br> > This patch defines the structures of ioctls that are used between<br> > win-vdagent and the qxl-wddm-dod driver.<br> ><br> <br> </span>???<br> <br> didn't we decide to remove this?<br> <span><span style="color: #888888;" data-mce-style="color: #888888;" color="#888888"><br></span></span></blockquote><div>Yes, but this is still used in the driver to determine the ioctl.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span><span style="color: #888888;" data-mce-style="color: #888888;" color="#888888"> Frediano<br> </span></span><div><div><br> > Signed-off-by: Sameeh Jubran <<a href="mailto:sameeh@daynix.com" target="_blank">sameeh@daynix.com</a>><br> > ---<br> > spice/qxl_windows.h | 10 +++++++++-<br> > 1 file changed, 9 insertions(+), 1 deletion(-)<br> ><br> > diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h<br> > index bc2ceff..85f9d79 100644<br> > --- a/spice/qxl_windows.h<br> > +++ b/spice/qxl_windows.h<br> > @@ -2,7 +2,7 @@<br> > #define _H_QXL_WINDOWS<br> ><br> > #include <spice/types.h><br> > -<br> > +#include <spice/qxl_dev.h><br> > #include <spice/start-packed.h><br> ><br> > enum {<br> > @@ -16,6 +16,14 @@ typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay<br> > {<br> > uint32_t bpp;<br> > } QXLEscapeSetCustomDisplay;<br> ><br> > +typedef struct SPICE_ATTR_PACKED QXLEscape {<br> > + uint32_t ioctl;<br> > + union {<br> > + QXLEscapeSetCustomDisplay custom_display;<br> > + QXLHead monitor_config;<br> > + };<br> > +} QXLEscape;<br> > +<br> > #include <spice/end-packed.h><br> ><br> > #endif /* _H_QXL_WINDOWS */<br> <br> </div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" color="#0b5394" face="times new roman, serif" size="4">Respectfully,<br></span><div style="font-size:12.8px;color:rgb(136,136,136)"><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" color="#0b5394" face="times new roman, serif" size="4"><b><i>Sameeh Jubran</i></b></span></div><div style="font-size:12.8px;color:rgb(136,136,136)"><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large"><span style="line-height:15px"><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="m_-7402188406148605883_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank">Linkedin</a></span></i><br></div><div style="font-size:12.8px;color:rgb(136,136,136)"><span style="color: #073763; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #073763; font-family: times new roman,serif; font-size: large;" color="#073763" face="times new roman, serif" size="4"><i>Junior Software Engineer @ <a href="http://www.daynix.com" target="_blank">Daynix</a>.</i></span></div></div></div></div></div></div></div> </div></div> </blockquote><div><br></div></div></body></html>