<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Frediano,<div class=""><br class=""></div><div class="">A thought we already agreed on this before:</div><div class=""><br class=""></div><div class=""><div class=""><div class="" style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"><div class=""><a href="https://github.com/vrozenfe/qxl-dod" class="">https://github.com/vrozenfe/qxl-dod</a> - outdated, no new commits will go there</div><div class=""><div class=""><div class="" style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"><div class=""><a href="https://gitlab.com/spice/qxl-wddm-dod" class="">https://gitlab.com/spice/qxl-wddm-dod</a> - the new main one - we expect that our patches will be applied to this repository</div><div class=""><div class=""><div class="" style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"><div class=""><a href="https://cgit.freedesktop.org/spice/win32/qxl-wddm-dod/" class="">https://cgit.freedesktop.org/spice/win32/qxl-wddm-dod/</a> - yes, we can access it, this repository should be dropped or become mirror of gitlab.</div></div></div></div><div class=""><br class=""></div><div class="">As to <a href="https://github.com/flexVDI/qxl-dod" style="font-size: 12pt;" class="">https://github.com/flexVDI/qxl-dod</a><span style="font-size: 12pt;" class=""> - Javier told that he will rebase his work on top of our patches as soon as they pushed to the main repository, i.e. to the gitlab.</span></div></div></div></div></div></div></div><div class=""><br class=""></div><div class="">Does this answer your questions?</div><div class=""><br class=""></div><div class="">Best Regards,</div><div class="">Dmitry</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 1 Sep 2016, at 16:12 PM, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><div class="">Hi,</div><div class=""> sorry for the latency.<br class=""></div><div class=""><br class=""></div><div class="">However there are some base problems on these patches. One big one it's the repository. As this is not public once we ack the patches where are you putting them? Just changing the comment on the private branch?<br class=""></div><div class="">Actually there are multiple repositories public:<br class=""></div><div class="">1- <a href="https://github.com/vrozenfe/qxl-dod," class="">https://github.com/vrozenfe/qxl-dod,</a> original one<br class=""></div><div class="">2- <a href="https://gitlab.com/spice/qxl-wddm-dod/commits/master" class="">https://gitlab.com/spice/qxl-wddm-dod/commits/master</a>, a copy on gitlab, not sure if this is supposed to be the main one, actually commits are identical to 1<br class=""></div><div class="">3- <a href="https://github.com/flexVDI/qxl-dod" class="">https://github.com/flexVDI/qxl-dod</a>, FlexVDI additional patches, contains 1/2 + additions.<br class=""></div><div class=""><br class=""></div><div class="">Personally I pushed the common patches in <a href="https://cgit.freedesktop.org/spice/win32/qxl-wddm-dod/" class="">https://cgit.freedesktop.org/spice/win32/qxl-wddm-dod/</a>. Can you access it?<br class=""></div><div class=""><br class=""></div><div class="">Another problem is the ownership of the patches. Some changes are inside FlexVDI patches, merged possibly to other ones and with a different owner. One example is the new delete operator from Javier. These issue should be fixed. Still doing on a private branch is quite difficult and not in line with OpenSource.<br class=""></div><div class=""><br class=""></div><div class="">I contacted Vadim asking for the state of its GitHub repository and said the beside the last patch the state is fine, I think we should start from that commit (<a href="https://github.com/vrozenfe/qxl-dod/commit/4e1b33dd4d4f9bb5ee58d13c2a88f8ed610afc41" class="">https://github.com/vrozenfe/qxl-dod/commit/4e1b33dd4d4f9bb5ee58d13c2a88f8ed610afc41</a>) which is also included in your private repository.<br class=""></div><div class=""><br class=""></div><div class="">To sum up: We _need_ the common public main repository.<br class=""></div><div class=""><br class=""></div><div class="">Frediano<br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><hr id="zwchr" class=""><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><b class="">From: </b>"Sameeh Jubran" <<a href="mailto:sameeh@daynix.com" class="">sameeh@daynix.com</a>><br class=""><b class="">To: </b>"Spice List" <<a href="mailto:spice-devel@lists.freedesktop.org" class="">spice-devel@lists.freedesktop.org</a>><br class=""><b class="">Cc: </b>"Dmitry Fleytman" <<a href="mailto:dmitry@daynix.com" class="">dmitry@daynix.com</a>>, "Frediano Ziglio" <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>><br class=""><b class="">Sent: </b>Tuesday, August 30, 2016 1:18:19 PM<br class=""><b class="">Subject: </b>Re: [PATCH qxl-wddm-dod 00/26] Win10 support patches<br class=""><div class=""><br class=""></div><div dir="ltr" class=""><div dir="ltr" style="font-size:12.8px" class="">Can anyone review the rest of the patches? (8 - 26)</div><div style="font-size:12.8px" class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Aug 24, 2016 at 4:22 PM, Sameeh Jubran <span dir="ltr" class=""><<a href="mailto:sameeh@daynix.com" target="_blank" class="">sameeh@daynix.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Can you please review the rest of the patches so I can send v2?</div><div class="gmail_extra"><div class=""><div class="h5"><br class=""><div class="gmail_quote">On Tue, Aug 9, 2016 at 6:28 PM, Sameeh Jubran <span dir="ltr" class=""><<a href="mailto:sameeh@daynix.com" target="_blank" class="">sameeh@daynix.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This series contains the latest patches to support Windows 10.<br class="">
<br class="">
Visual Studio 2015 with Win10 WDK is required to compile this code,<br class="">
Current patches may be compiled and will work for Windows 10.<br class="">
<br class="">
Smoke testing had been done in windows 8.1 seems to be working good.<br class="">
<br class="">
Dmitry Fleytman (4):<br class="">
Replacing <#ifdef USE_FRAMEBUFFER> with runtime logic<br class="">
Fixing framebuffer usage logic<br class="">
Support future Qxl revisions<br class="">
Set SupportNonVGA in QueryAdapterInfo callback<br class="">
<br class="">
Sameeh Jubran (9):<br class="">
Upgrade to Windows 10 WDK<br class="">
Add delete operator<br class="">
Code Analysis clean up<br class="">
Replacing tabs with spaces<br class="">
Fix source buffer mapping in PresentDisplayOnly<br class="">
Fixing Move rectangles implementation<br class="">
Reserved must be set to 0<br class="">
Fixing monitor flicker on resolution change<br class="">
Removing unnecessary call to BlackOutScreen<br class="">
<br class="">
Sandy Stutsman (13):<br class="">
Add printer class to dump debug print statements to kernel debugger<br class="">
output<br class="">
Set DriverStarted flag at the begining of the StartDriver function<br class="">
Fix Code Integrity error generated by the Drive Verifier<br class="">
Add functions called from non-pageable functions to non-paged segments<br class="">
Do not use virtual functions for code that must not be paged<br class="">
On power wake call the init functions before setting the vidpn to<br class="">
black. Otherwise, BSOD.<br class="">
Use SrcPitch when calculating size of memory to map PresentDisplayOnly<br class="">
Remove unused notify present display only interrupt and fix interrupt<br class="">
mask<br class="">
Add arbitrary resolution and monitors_config Escape<br class="">
Use the second bar (VRAM) for qxl command buffer.<br class="">
Comment out frame buffer mapping.<br class="">
Enable HW cursor support and fix handling of monochrome cursors.<br class="">
Remove minimum size restrict for custom resolution.<br class="">
<br class="">
Tools/vs_cmdline.vbs | 23 +<br class="">
Tools/vs_run.bat | 26 +<br class="">
buildAll.bat | 15 +<br class="">
buildAll_NoSign.bat | 19 +<br class="">
qxldod Package/qxldod Package.vcxproj | 173 +-<br class="">
qxldod Package/qxldod Package.vcxproj.user | 15 +<br class="">
qxldod.sln | 106 +-<br class="">
qxldod/BaseObject.cpp | 11 +<br class="">
qxldod/BaseObject.h | 1 +<br class="">
qxldod/QxlDod.cpp | 1280 +++++++++------<br class="">
qxldod/QxlDod.h | 67 +-<br class="">
qxldod/buildAll.bat | 31 -<br class="">
qxldod/callVisualStudio.bat | 28 -<br class="">
qxldod/checkWin8Tools.bat | 8 -<br class="">
qxldod/clean.bat | 12 -<br class="">
qxldod/driver.cpp | 26 +-<br class="">
qxldod/driver.h | 20 +-<br class="">
qxldod/include/qxl_windows.h | 1 +<br class="">
qxldod/mspace.c | 2437 ---------------------------<br class="">
qxldod/mspace.cpp | 2439 ++++++++++++++++++++++++++++<br class="">
qxldod/qxldod.vcxproj | 247 ++-<br class="">
qxldod/qxldod.vcxproj.filters | 2 +-<br class="">
qxldod/qxldod.vcxproj.user | 15 +<br class="">
23 files changed, 3619 insertions(+), 3383 deletions(-)<br class="">
create mode 100644 Tools/vs_cmdline.vbs<br class="">
create mode 100644 Tools/vs_run.bat<br class="">
create mode 100644 buildAll.bat<br class="">
create mode 100644 buildAll_NoSign.bat<br class="">
create mode 100644 qxldod Package/qxldod Package.vcxproj.user<br class="">
delete mode 100755 qxldod/buildAll.bat<br class="">
delete mode 100755 qxldod/callVisualStudio.bat<br class="">
delete mode 100755 qxldod/checkWin8Tools.bat<br class="">
delete mode 100755 qxldod/clean.bat<br class="">
delete mode 100755 qxldod/mspace.c<br class="">
create mode 100644 qxldod/mspace.cpp<br class="">
create mode 100644 qxldod/qxldod.vcxproj.user<br class="">
<span class=""><span style="color: #888888;" data-mce-style="color: #888888;" class=""><br class="">
--<br class="">
2.7.0.windows.1<br class="">
<br class="">
</span></span></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div></div></div><span class="HOEnZb"><span style="color: #888888;" data-mce-style="color: #888888;" class="">-- <br class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class="">Respectfully,<br class=""></span><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class=""><b class=""><i class="">Sameeh Jubran</i></b></span></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large" class=""><span style="line-height:15px" class=""><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="m_-2673508370415014336_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank" class="">Linkedin</a></span></i><br class=""></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color: #073763; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #073763; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class=""><i class="">Junior Software Engineer @ <a href="http://www.daynix.com/" target="_blank" class="">Daynix</a>.</i></span></div></div></div></div></div></div></div>
</span></span></div>
</blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class="">Respectfully,<br class=""></span><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color: #0b5394; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #0b5394; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class=""><b class=""><i class="">Sameeh Jubran</i></b></span></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large" class=""><span style="line-height:15px" class=""><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank" class="">Linkedin</a></span></i><br class=""></div><div style="font-size:12.8px;color:rgb(136,136,136)" class=""><span style="color: #073763; font-family: times new roman,serif; font-size: large;" data-mce-style="color: #073763; font-family: times new roman,serif; font-size: large;" face="times new roman, serif" size="4" class=""><i class="">Junior Software Engineer @ <a href="http://www.daynix.com/" target="_blank" class="">Daynix</a>.</i></span></div></div></div></div></div></div></div>
</div>
</blockquote><div class=""><br class=""></div></div></div></div></blockquote></div><br class=""></div></body></html>