<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><div><br></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>From: </b>"Frediano Ziglio" <fziglio@redhat.com><br><b>To: </b>"Dmitry Fleytman" <dmitry@daynix.com><br><b>Cc: </b>"Spice List" <spice-devel@lists.freedesktop.org><br><b>Sent: </b>Tuesday, September 6, 2016 1:30:44 PM<br><b>Subject: </b>Re: [Spice-devel] [PATCH qxl-wddm-dod v2 12/25] Rename mspace.c to mspace.cpp<br><div><br></div><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><blockquote class=""><div class="">On 6 Sep 2016, at 15:07 PM, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="" target="_blank">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div dir="ltr" class=""><div class="gmail_extra">On Mon, Sep 5, 2016 at 9:26 PM, Frediano Ziglio <span dir="ltr" class=""><<a href="mailto:fziglio@redhat.com" target="_blank" class="">fziglio@redhat.com</a>></span> wrote:<br class=""><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Why the rationale was removed?<br class=""><br class=""></blockquote><div class="">By mistake, i'll add it back in the next version. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">By the way this was a workaround for a VS bug, get Visual Studio 2015 Update 1 (actually we are at update 3)<br class=""></blockquote><div class="">True, however microsoft recommends using visual c++ compiler profile as it is different from the c compiler profile.</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">Yes, especially if you don't know what you are doing and you don't have a acceptable test suite.<br class=""></div><div class="">I hope that they all don't apply to us.<br class=""></div></div></div></div></blockquote><div><br class=""></div><div><br class=""></div><div>Hi Frediano,</div><div><br class=""></div><div>Actually using Microsoft C++ compiler for C files is recommended because it performs</div><div>more excessive static checks and produces warnings regarding more potential problematic cases.</div><div>And this is definitely a good thing.</div><div><br class=""></div><div>~Dmitry</div></div></blockquote><div><div>Yes... C++ does more strictly checks. This does not means that all C programmers are moving to a C++ compiler!</div></div></div></blockquote><div>The mspace.c file is shared between different projects where some require it to be C.<br></div><div>Rename to .cpp can cause maintainability issue as it's easier to introduce C++ construct that would lead to a fork.<br></div><div>As the initial rationale (a workaround for a VS bug) didn't apply anymore I would avoid the rename.<br></div><div><br></div><div>Frediano</div><div><br></div></div></body></html>