<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Sep 6, 2016 at 5:16 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:times new roman,new york,times,serif;font-size:12pt;color:#000000"><div><div class="h5"><blockquote style="border-left:2px solid #1010ff;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 6, 2016 at 5:07 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>><br>
> From: Sandy Stutsman <<a href="mailto:sstutsma@redhat.com" target="_blank">sstutsma@redhat.com</a>><br>
><br>
> ---<br>
> qxldod/QxlDod.cpp | 5 ++---<br>
> 1 file changed, 2 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp<br>
> index 7e2d7c1..4dcfca3 100755<br>
> --- a/qxldod/QxlDod.cpp<br>
> +++ b/qxldod/QxlDod.cpp<br>
> @@ -4512,11 +4512,10 @@ NTSTATUS<br>
> QxlDevice::SetCustomDisplay(QXLEscapeSetCustomDisplay* custom_display)<br>
> UINT xres = custom_display->xres;<br>
> UINT yres = custom_display->yres;<br>
> UINT bpp = QXL_BPP;<br>
> - DbgPrint(TRACE_LEVEL_ERROR, ("%s - %d (%dx%d#%d)\n", __FUNCTION__, m_Id,<br>
> xres, yres, bpp));<br>
> + DbgPrint(TRACE_LEVEL_WARNING, ("%s - %d (%dx%d#%d)\n", __FUNCTION__,<br>
> m_Id, xres, yres, bpp));<br>
> if (xres < MIN_WIDTH_SIZE || yres < MIN_HEIGHT_SIZE) {<br>
> - DbgPrint(TRACE_LEVEL_VERBOSE, ("%s: (%dx%d#%d) must be at least<br>
> (%dxd)\n", __FUNCTION__,<br>
> + DbgPrint(TRACE_LEVEL_VERBOSE, ("%s: (%dx%d#%d) less than (%dxd)\n",<br>
> __FUNCTION__,<br>
> xres, yres, bpp, MIN_WIDTH_SIZE, MIN_HEIGHT_SIZE));<br>
> - return ERROR_INVALID_DATA;<br>
> }<br>
> m_CustomMode =(USHORT) ((m_CustomMode == m_ModeCount-1)? m_ModeCount -<br>
> 2 : m_ModeCount - 1);<br>
><br><div><br></div></div></div>This patch is just changing some logging message.<br></blockquote><div>Not true, as it removes the line "return ERROR_INVALID_DATA;" which would</div><div>prevent the function from changing the resolution.</div></div></div></div></blockquote></div></div><div>Oh, yes you are right.<br></div><div><br></div><div>I would however prefer this patch<br></div><div><a href="https://github.com/flexVDI/qxl-dod/commit/9cc669ab31d31598bd3ca6431f24891bfe40fbae" target="_blank">https://github.com/flexVDI/qxl-dod/commit/9cc669ab31d31598bd3ca6431f24891bfe40fbae</a><br data-mce-bogus="1"></div><div>Windows cannot handle very low resolutions. I actually think that the minimum was moved<br></div><div>to 800x600 in Windows Vista/7.</div></div></div></blockquote><div>It is the recommended minimum, however Windows can handle low resolution just fine. We have tested that,</div><div>even the old driver behaves like this. I see no reason for making any restriction at all. </div></div></div></div></blockquote><div>Acked-by: Frediano Ziglio <fziglio@redhat.com><br></div><div><br></div><div>Frediano<br></div><div><br></div></div></body></html>