<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 6 Sep 2016, at 15:45 PM, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline"><br class=""></div><hr id="zwchr" style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote style="font-size: 12pt; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; text-decoration: none; font-family: Helvetica, Arial, sans-serif;" class=""><b class="">From:<span class="Apple-converted-space"> </span></b>"Frediano Ziglio" <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>><br class=""><b class="">To:<span class="Apple-converted-space"> </span></b>"Dmitry Fleytman" <<a href="mailto:dmitry@daynix.com" class="">dmitry@daynix.com</a>><br class=""><b class="">Cc:<span class="Apple-converted-space"> </span></b>"Spice List" <<a href="mailto:spice-devel@lists.freedesktop.org" class="">spice-devel@lists.freedesktop.org</a>><br class=""><b class="">Sent:<span class="Apple-converted-space"> </span></b>Tuesday, September 6, 2016 1:30:44 PM<br class=""><b class="">Subject:<span class="Apple-converted-space"> </span></b>Re: [Spice-devel] [PATCH qxl-wddm-dod v2 12/25] Rename mspace.c to mspace.cpp<br class=""><div class=""><br class=""></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div class=""><blockquote class=""><div class="">On 6 Sep 2016, at 15:07 PM, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="" target="_blank">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><div class="" style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;"><blockquote class="" style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;"><div dir="ltr" class=""><div class="gmail_extra">On Mon, Sep 5, 2016 at 9:26 PM, Frediano Ziglio<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:fziglio@redhat.com" target="_blank" class="">fziglio@redhat.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Why the rationale was removed?<br class=""><br class=""></blockquote><div class="">By mistake, i'll add it back in the next version. </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">By the way this was a workaround for a VS bug, get Visual Studio 2015 Update 1 (actually we are at update 3)<br class=""></blockquote><div class="">True, however microsoft recommends using visual c++ compiler profile as it is different from the c compiler profile.</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">Yes, especially if you don't know what you are doing and you don't have a acceptable test suite.<br class=""></div><div class="">I hope that they all don't apply to us.<br class=""></div></div></div></div></blockquote><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Hi Frediano,</div><div class=""><br class=""></div><div class="">Actually using Microsoft C++ compiler for C files is recommended because it performs</div><div class="">more excessive static checks and produces warnings regarding more potential problematic cases.</div><div class="">And this is definitely a good thing.</div><div class=""><br class=""></div><div class="">~Dmitry</div></div></blockquote><div class=""><div class="">Yes... C++ does more strictly checks. This does not means that all C programmers are moving to a C++ compiler!</div></div></div></blockquote><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">The mspace.c file is shared between different projects where some require it to be C.<br class=""></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Rename to .cpp can cause maintainability issue as it's easier to introduce C++ construct that would lead to a fork.<br class=""></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">As the initial rationale (a workaround for a VS bug) didn't apply anymore I would avoid the rename.<br class=""></div></div></blockquote><div><br class=""></div><div>Sure. No problem.</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Frediano</div></div></blockquote></div><br class=""></body></html>