<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 28, 2016 at 3:06 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">><br>
> Based on a patch by Sandy Stutsman <<a href="mailto:sstutsma@redhat.com">sstutsma@redhat.com</a>><br>
><br>
> Signed-off-by: Sameeh Jubran <<a href="mailto:sameeh@daynix.com">sameeh@daynix.com</a>><br>
<br>
</span>Acked-by: Frediano Ziglio <<a href="mailto:fziglio@redhat.com">fziglio@redhat.com</a>><br>
<div><div class="h5"><br>
> ---<br>
>  qxldod/QxlDod.cpp | 9 +++++----<br>
>  1 file changed, 5 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp<br>
> index 2bc6b77..577b4ff 100755<br>
> --- a/qxldod/QxlDod.cpp<br>
> +++ b/qxldod/QxlDod.cpp<br>
> @@ -1493,7 +1493,7 @@ NTSTATUS QxlDod::CommitVidPn(_In_ CONST<br>
> DXGKARG_COMMITVIDPN* CONST pCommitVidPn)<br>
><br>
>  CommitVidPnExit:<br>
><br>
> -    NTSTATUS TempStatus;<br>
> +    NTSTATUS TempStatus(STATUS_SUCCESS);<br>
>      UNREFERENCED_PARAMETER(<wbr>TempStatus);<br>
><br>
>      if ((pVidPnSourceModeSetInterface != NULL) &&<br>
> @@ -1851,7 +1851,7 @@ NTSTATUS QxlDod::WriteHWInfoStr(_In_ HANDLE<br>
> DevInstRegKeyHandle, _In_ PCWSTR psz<br>
>  }<br>
><br>
>  QXL_PAGED<br>
> -NTSTATUS QxlDod::RegisterHWInfo(ULONG Id)<br>
> +NTSTATUS QxlDod::RegisterHWInfo(_In_ ULONG Id)<br>
>  {<br>
>      PAGED_CODE();<br>
><br>
> @@ -3247,7 +3247,7 @@ NTSTATUS QxlDevice::GetCurrentMode(<wbr>ULONG* pMode)<br>
>  }<br>
><br>
>  QXL_PAGED<br>
> -NTSTATUS QxlDevice::SetPowerState(_In_ DEVICE_POWER_STATE DevicePowerState,<br>
> DXGK_DISPLAY_INFORMATION* pDispInfo)<br>
> +NTSTATUS QxlDevice::SetPowerState(<wbr>DEVICE_POWER_STATE DevicePowerState,<br>
> DXGK_DISPLAY_INFORMATION* pDispInfo)<br>
>  {<br>
>      PAGED_CODE();<br>
>      DbgPrint(TRACE_LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__));<br>
<br>
</div></div>After merging I realize that in a previous patch the same change<br>
was done for VgaDevice::SetPowerState.<br>
Was this removal intentional or a mistake?<br></blockquote><div>A mistake, what should we do? </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Frediano<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="4" color="#0b5394" face="times new roman, serif">Respectfully,<br></font><div style="font-size:12.8px;color:rgb(136,136,136)"><font size="4" color="#0b5394" face="times new roman, serif"><b><i>Sameeh Jubran</i></b></font></div><div style="font-size:12.8px;color:rgb(136,136,136)"><i style="color:rgb(7,55,99);font-family:"times new roman",serif;font-size:large"><span style="line-height:15px"><a href="https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a" title="View public profile" name="UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_14e2c1de96f8c195_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter_SafeHtmlFilter_webProfileURL" style="color:rgb(17,85,204);margin:0px;padding:0px;border-width:0px;outline:none;vertical-align:baseline;text-decoration:none" target="_blank">Linkedin</a></span></i><br></div><div style="font-size:12.8px;color:rgb(136,136,136)"><font size="4" face="times new roman, serif" color="#073763"><i>Junior Software Engineer @ <a href="http://www.daynix.com" target="_blank">Daynix</a>.</i></font></div></div></div></div></div></div></div>
</div></div>