<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 28, 2016 at 3:06 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">><br>
> Based on a patch by Sandy Stutsman <<a href="mailto:sstutsma@redhat.com" target="_blank">sstutsma@redhat.com</a>><br>
><br>
> Signed-off-by: Sameeh Jubran <<a href="mailto:sameeh@daynix.com" target="_blank">sameeh@daynix.com</a>><br>
<br>
</span>Acked-by: Frediano Ziglio <<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>><br><div><div class="h5"><br>
> ---<br>
> qxldod/QxlDod.cpp | 9 +++++----<br>
> 1 file changed, 5 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp<br>
> index 2bc6b77..577b4ff 100755<br>
> --- a/qxldod/QxlDod.cpp<br>
> +++ b/qxldod/QxlDod.cpp<br>
> @@ -1493,7 +1493,7 @@ NTSTATUS QxlDod::CommitVidPn(_In_ CONST<br>
> DXGKARG_COMMITVIDPN* CONST pCommitVidPn)<br>
><br>
> CommitVidPnExit:<br>
><br>
> - NTSTATUS TempStatus;<br>
> + NTSTATUS TempStatus(STATUS_SUCCESS);<br>
> UNREFERENCED_PARAMETER(TempStatus);<br>
><br>
> if ((pVidPnSourceModeSetInterface != NULL) &&<br>
> @@ -1851,7 +1851,7 @@ NTSTATUS QxlDod::WriteHWInfoStr(_In_ HANDLE<br>
> DevInstRegKeyHandle, _In_ PCWSTR psz<br>
> }<br>
><br>
> QXL_PAGED<br>
> -NTSTATUS QxlDod::RegisterHWInfo(ULONG Id)<br>
> +NTSTATUS QxlDod::RegisterHWInfo(_In_ ULONG Id)<br>
> {<br>
> PAGED_CODE();<br>
><br>
> @@ -3247,7 +3247,7 @@ NTSTATUS QxlDevice::GetCurrentMode(ULONG* pMode)<br>
> }<br>
><br>
> QXL_PAGED<br>
> -NTSTATUS QxlDevice::SetPowerState(_In_ DEVICE_POWER_STATE DevicePowerState,<br>
> DXGK_DISPLAY_INFORMATION* pDispInfo)<br>
> +NTSTATUS QxlDevice::SetPowerState(DEVICE_POWER_STATE DevicePowerState,<br>
> DXGK_DISPLAY_INFORMATION* pDispInfo)<br>
> {<br>
> PAGED_CODE();<br>
> DbgPrint(TRACE_LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__));<br><br></div></div>After merging I realize that in a previous patch the same change<br>
was done for VgaDevice::SetPowerState.<br>
Was this removal intentional or a mistake?<br></blockquote><div>A mistake, what should we do? </div></div></div></div></blockquote><div><br>Sent a new patch that add the missing hunk from the previous patch.<br></div><div><br></div><div>Frediano</div><div><br></div></div></body></html>