<div dir="ltr">Is this a best idea to send down HIDE command on each SetPointerPosition?<div>I'd like to check it - may be we can filter it better on SetPointerShape?</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 18, 2016 at 7:07 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Javier Celaya <<a href="mailto:javier.celaya@flexvdi.com">javier.celaya@flexvdi.com</a>><br>
<br>
This avoid having possibly 2 pointers (client and server) if Windows<br>
decide to render the mouse by itself.<br>
This happens for instance moving windows.<br>
<br>
---<br>
qxldod/QxlDod.cpp | 7 +------<br>
1 file changed, 1 insertion(+), 6 deletions(-)<br>
<br>
Javier, as we changed license since you create it could you please sign off<br>
the patch?<br>
<br>
I added some comments to this patch.<br>
<br>
diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp<br>
index 724e89f..8f31714 100755<br>
--- a/qxldod/QxlDod.cpp<br>
+++ b/qxldod/QxlDod.cpp<br>
@@ -434,11 +434,6 @@ NTSTATUS QxlDod::SetPointerPosition(_<wbr>In_ CONST DXGKARG_SETPOINTERPOSITION* pSetP<br>
QXL_ASSERT(pSetPointerPosition != NULL);<br>
QXL_ASSERT(<wbr>pSetPointerPosition-><wbr>VidPnSourceId < MAX_VIEWS);<br>
<br>
- if (!(pSetPointerPosition->Flags.<wbr>Visible))<br>
- {<br>
- DbgPrint(TRACE_LEVEL_<wbr>INFORMATION, ("<--- %s Cursor is not visible\n", __FUNCTION__));<br>
- return STATUS_SUCCESS;<br>
- }<br>
return m_pHWDevice-><wbr>SetPointerPosition(<wbr>pSetPointerPosition);<br>
}<br>
<br>
@@ -4507,7 +4502,7 @@ NTSTATUS QxlDevice::SetPointerPosition(<wbr>_In_ CONST DXGKARG_SETPOINTERPOSITION* pS<br>
pSetPointerPosition->X,<br>
pSetPointerPosition->Y));<br>
QXLCursorCmd *cursor_cmd = CursorCmd();<br>
- if (pSetPointerPosition->X < 0) {<br>
+ if (pSetPointerPosition->X < 0 || !pSetPointerPosition->Flags.<wbr>Visible) {<br>
cursor_cmd->type = QXL_CURSOR_HIDE;<br>
} else {<br>
cursor_cmd->type = QXL_CURSOR_MOVE;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/spice-devel</a><br>
</font></span></blockquote></div><br></div>