<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 27, 2017 at 12:06 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This is a follow up of 31ca5d035d2b24912044ef69ff23b3<wbr>b854cd72dd<br>
("Implements screen to screen move correctly").<br>
<br>
As now we don't copy memory to implement moves there's no<br>
reason to take into account these area for memory mappings<br>
as memory is not accessed anymore.<br>
<br>
Signed-off-by: Frediano Ziglio <<a href="mailto:fziglio@redhat.com">fziglio@redhat.com</a>><br>
---<br>
qxldod/QxlDod.cpp | 11 ++---------<br>
qxldod/QxlDod.h | 2 +-<br>
2 files changed, 3 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp<br>
index 001cd67..e47f302 100755<br>
--- a/qxldod/QxlDod.cpp<br>
+++ b/qxldod/QxlDod.cpp<br>
@@ -3638,7 +3638,7 @@ QxlDevice::<wbr>ExecutePresentDisplayOnly(<br>
// Source bitmap is in user mode, must be locked under __try/__except<br>
// and mapped to kernel space before use.<br>
{<br>
- LONG maxHeight = GetMaxSourceMappingHeight(ctx-<wbr>>Moves, ctx->NumMoves, ctx->DirtyRect, ctx->NumDirtyRects);<br>
+ LONG maxHeight = GetMaxSourceMappingHeight(ctx-<wbr>>DirtyRect, ctx->NumDirtyRects);<br>
UINT sizeToMap = ctx->SrcPitch * maxHeight;<br>
<br>
PMDL mdl = IoAllocateMdl((PVOID)SrcAddr, sizeToMap, FALSE, FALSE, NULL);<br>
@@ -4533,17 +4533,10 @@ void QxlDevice::SetMonitorConfig(<wbr>QXLHead * monitor_config)<br>
AsyncIo(QXL_IO_MONITORS_<wbr>CONFIG_ASYNC, 0);<br>
}<br>
<br>
-LONG QxlDevice::<wbr>GetMaxSourceMappingHeight(<wbr>D3DKMT_MOVE_RECT* Moves, ULONG NumMoves, RECT* DirtyRects, ULONG NumDirtyRects)<br>
+LONG QxlDevice::<wbr>GetMaxSourceMappingHeight(<wbr>RECT* DirtyRects, ULONG NumDirtyRects)<br>
{<br>
PAGED_CODE();<br>
LONG maxHeight = 0;<br>
- if (Moves != NULL) {<br>
- for (UINT i = 0; i < NumMoves; i++) {<br>
- const POINT& pSourcePoint = Moves[i].SourcePoint;<br>
- const RECT& pDestRect = Moves[i].DestRect;<br>
- maxHeight = MAX(maxHeight, pDestRect.bottom - pDestRect.top + pSourcePoint.y);<br>
- }<br>
- }<br>
if (DirtyRects != NULL) {<br>
for (UINT i = 0; i < NumDirtyRects; i++) {<br>
const RECT& pDirtyRect = DirtyRects[i];<br>
diff --git a/qxldod/QxlDod.h b/qxldod/QxlDod.h<br>
index 8df1fcf..e782dfb 100755<br>
--- a/qxldod/QxlDod.h<br>
+++ b/qxldod/QxlDod.h<br>
@@ -555,7 +555,7 @@ private:<br>
NTSTATUS SetCustomDisplay(<wbr>QXLEscapeSetCustomDisplay* custom_display);<br>
void SetMonitorConfig(QXLHead* monitor_config);<br>
<br>
- static LONG GetMaxSourceMappingHeight(<wbr>D3DKMT_MOVE_RECT* Moves, ULONG NumMoves, RECT* DirtyRects, ULONG NumDirtyRects);<br>
+ static LONG GetMaxSourceMappingHeight(<wbr>RECT* DirtyRects, ULONG NumDirtyRects);<br>
<br>
private:<br>
PUCHAR m_IoBase;<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.9.3<br>
<br></font></span></blockquote><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Acked-by: Yuri Benditovich <</span><a href="mailto:yuri.benditovich@daynix.com" target="_blank" style="font-size:12.8px">yuri.benditovich@daynix.com</a><span style="font-size:12.8px">></span></div><div><span style="font-size:12.8px"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-HOEnZb"><font color="#888888">
______________________________<wbr>_________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/spice-devel</a><br>
</font></span></blockquote></div><br></div></div>