<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""><div><blockquote type="cite" class=""><div class="">On 6 Mar 2017, at 11:42, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div class=""><blockquote class=""><div class="">On 3 Mar 2017, at 13:10, Marc-André Lureau <<a href="mailto:mlureau@redhat.com" class="" target="_blank">mlureau@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Hi</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">----- Original Message -----</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote class=""><br class="">Hi<br class=""><br class="">----- Original Message -----<br class=""><blockquote class="">These 2 patches attempt to join images split by RHEL7 graphic<br class="">stack (Mesa) decreasing commands handled by spice-server.<br class=""><br class="">You can see the difference between the 2 video:<br class="">-<span class="Apple-converted-space"> </span><a href="https://www.youtube.com/watch?v=OarV6zUmUdg" class="" target="_blank">https://www.youtube.com/watch?v=OarV6zUmUdg</a><span class="Apple-converted-space"> </span>(before)<br class="">-<span class="Apple-converted-space"> </span><a href="https://www.youtube.com/watch?v=5fTdCCbFeCg" class="" target="_blank">https://www.youtube.com/watch?v=5fTdCCbFeCg</a><span class="Apple-converted-space"> </span>(after)<br class="">These video are realized with some additional changes:<br class="">- the statistics from the terminal have some additional<br class=""> "out_messages" counters. These counters show the messages<br class=""> sent to the client(s). These changes are part of my "stat"<br class=""> branch (partially sent couple of days ago);<br class="">- the replay utility, as you can see, was changed to replay<br class=""> using the real time to allow the video code (which is dependent<br class=""> on timing) to work correctly. The patch is currently not in<br class=""> a good shape (enough to be sent);<br class="">- the client utility was changed to remove the delay due to<br class=""> the lip sync. The glitches (present mostly before these patches)<br class=""> are much reduced.<br class=""><br class="">Note the number of commands sent to the client reduced from 6097<br class="">to 2016 (current year, just a coincidence).<br class="">The network traffic reduced from 72M to 56M. This is due to the fact<br class="">that having a single stream (as you can see VP8 codec was used) the<br class="">compression on the stream is better.<br class=""><br class="">These patches fix:<br class="">-<span class="Apple-converted-space"> </span><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1158029" class="" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1158029</a>;<br class="">-<span class="Apple-converted-space"> </span><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1294564" class="" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1294564</a><span class="Apple-converted-space"> </span>(probably).<br class=""><br class="">In some experiments with the modified replay utility I got<br class="">some additional artifacts respect to the RFC version. This is mainly<br class="">due to the way RedWorker handle commands from graphic driver and the<br class="">way the timeout was handled. In the previous version before checking<br class="">for joining timeout the graphic command queue were always checked<br class="">while with this last series is possible that the timeout trigger<br class="">before checking for new command. This however seems to happen mainly<br class="">to me as the replay utility introduce some delay.<br class=""></blockquote><br class="">How much extra CPU usage does this take? in non-degenerate case and<br class="">degenerated case.<br class=""><br class="">I would suggest to fix the root cause: that X splits and copy large region<br class="">update.<br class=""><br class="">The solution I proposed:<br class=""><a href="https://lists.freedesktop.org/archives/mesa-dev/2015-June/085860.html" class="" target="_blank">https://lists.freedesktop.org/archives/mesa-dev/2015-June/085860.html</a><br class=""><br class="">Not only it doesn't require extra work on Spice side, but it also improves<br class="">guest CPU usage by avoiding large memcpy (fullscreen video can be very<br class="">heavy)<br class=""><br class=""></blockquote><br class="">Fine with it.<br class="">Can you do it?<br class=""><br class=""></blockquote><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">I may eventually do it, but it's not in my priorities.</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">The last update from me was "[PATCHv2 0/9] drisw/glx: use XShm if possible" (6/15/15).</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Adam Jackson was supposed to review/take it. I don't know if anything happened since.</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Ajax, any update? could you look at it? I see the bug is assigned to Dave (rhbz#1030024)</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Anyone willing to take it?</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></div></blockquote><div class=""><br class=""></div><div class="">Willing I am. Able I don’t know ;-) If I’m stumped, I know who to call for help.</div><div class=""><br class=""></div><div class="">Christophe</div></div></blockquote><div class="">Would be great to have this fixed instead of a workaround!<br class=""></div><div class="">On the other way the only thing we could do is updating the patch, testing and pushing Mesa<br class=""></div><div class="">to merge it.<br class=""></div><div class="">Could we actually just accept the patch downstream, at least for 7.4 ?<br class=""></div><div class=""><br class=""></div><div class="">Posted a message in<span class="Apple-converted-space"> </span><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1030024" class="">https://bugzilla.redhat.com/show_bug.cgi?id=1030024</a><span class="Apple-converted-space"> </span>to ask<br class=""></div><div class="">for some commitment. Seems that the bug was stuck since an year.<br class=""></div></div></div></blockquote><div><br class=""></div><div>I adjusted the patch for the then-current version of mesa. See <a href="https://github.com/c3d/mesa/commit/6709e8c3bd8af5df9f748ee3449598aa1787fe51" class="">https://github.com/c3d/mesa/commit/6709e8c3bd8af5df9f748ee3449598aa1787fe51</a>. Updated rhbz1030024.<div class=""><br class=""></div><div class="">Christophe</div><div class=""><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""></blockquote></div></div></div></div><br class=""><blockquote type="cite" class=""><div class=""><div style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><div class=""><br class=""></div><div class="">Frediano</div><div class=""><br class=""></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Spice-devel mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:Spice-devel@lists.freedesktop.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Spice-devel@lists.freedesktop.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a></div></blockquote></div><br class=""></div></div></body></html>