<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 28, 2017 at 3:52 PM <<a href="mailto:marcandre.lureau@redhat.com">marcandre.lureau@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Marc-André Lureau <<a href="mailto:marcandre.lureau@redhat.com" class="gmail_msg" target="_blank">marcandre.lureau@redhat.com</a>><br class="gmail_msg">
<br class="gmail_msg">
intltool and glib-gettext are somehow related, and upstream gettext<br class="gmail_msg">
should now support everything needed for GNOME projects.<br class="gmail_msg">
<br class="gmail_msg">
intltool support never really worked, and we removed some of its<br class="gmail_msg">
commented usage a while ago when dropping spicy desktop/mime.<br class="gmail_msg">
<br class="gmail_msg">
Signed-off-by: Marc-André Lureau <<a href="mailto:marcandre.lureau@redhat.com" class="gmail_msg" target="_blank">marcandre.lureau@redhat.com</a>><br class="gmail_msg">
---<br class="gmail_msg">
Makefile.am | 16 +------------<br class="gmail_msg">
README | 2 +-<br class="gmail_msg">
autogen.sh | 1 -<br class="gmail_msg">
<a href="http://configure.ac" rel="noreferrer" class="gmail_msg" target="_blank">configure.ac</a> | 8 +++----<br class="gmail_msg">
po/Makevars | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++<br class="gmail_msg">
5 files changed, 82 insertions(+), 21 deletions(-)<br class="gmail_msg">
create mode 100644 po/Makevars<br class="gmail_msg">
<br class="gmail_msg">
diff --git a/Makefile.am b/Makefile.am<br class="gmail_msg">
index f462ae0..54a8a57 100644<br class="gmail_msg">
--- a/Makefile.am<br class="gmail_msg">
+++ b/Makefile.am<br class="gmail_msg">
@@ -26,20 +26,7 @@ if WITH_CONTROLLER<br class="gmail_msg">
pkgconfig_DATA += spice-controller.pc<br class="gmail_msg">
endif<br class="gmail_msg">
<br class="gmail_msg">
-INTLTOOL_FILES = \<br class="gmail_msg">
- <a href="http://intltool-extract.in" rel="noreferrer" class="gmail_msg" target="_blank">intltool-extract.in</a> \<br class="gmail_msg">
- <a href="http://intltool-merge.in" rel="noreferrer" class="gmail_msg" target="_blank">intltool-merge.in</a> \<br class="gmail_msg">
- <a href="http://intltool-update.in" rel="noreferrer" class="gmail_msg" target="_blank">intltool-update.in</a> \<br class="gmail_msg">
- $(NULL)<br class="gmail_msg">
-<br class="gmail_msg">
-DISTCLEANFILES = \<br class="gmail_msg">
- $(pkgconfig_DATA) \<br class="gmail_msg">
- intltool-extract \<br class="gmail_msg">
- intltool-merge \<br class="gmail_msg">
- intltool-update \<br class="gmail_msg">
- gnome-doc-utils.make \<br class="gmail_msg">
- po/.intltool-merge-cache \<br class="gmail_msg">
- $(NULL)<br class="gmail_msg">
+DISTCLEANFILES = $(pkgconfig_DATA)<br class="gmail_msg">
<br class="gmail_msg">
EXTRA_DIST = \<br class="gmail_msg">
build-aux/git-version-gen \<br class="gmail_msg">
@@ -53,7 +40,6 @@ MAINTAINERCLEANFILES = \<br class="gmail_msg">
$(GITIGNORE_MAINTAINERCLEANFILES_MAKEFILE_IN) \<br class="gmail_msg">
$(GITIGNORE_MAINTAINERCLEANFILES_M4_LIBTOOL) \<br class="gmail_msg">
m4/gtk-doc.m4 \<br class="gmail_msg">
- m4/intltool.m4 \<br class="gmail_msg">
gtk-doc.make \<br class="gmail_msg">
$(NULL)<br class="gmail_msg">
<br class="gmail_msg">
diff --git a/README b/README<br class="gmail_msg">
index 2ab5b67..1ea621a 100644<br class="gmail_msg">
--- a/README<br class="gmail_msg">
+++ b/README<br class="gmail_msg">
@@ -42,7 +42,7 @@ dnf builddep spice-gtk<br class="gmail_msg">
<br class="gmail_msg">
. or install:<br class="gmail_msg">
<br class="gmail_msg">
-gtk3-devel spice-protocol intltool<br class="gmail_msg">
+gtk3-devel spice-protocol<br class="gmail_msg">
openssl-devel pulseaudio-libs-devel pixman-devel<br class="gmail_msg">
gobject-introspection-devel libjpeg-turbo-devel zlib-devel<br class="gmail_msg">
cyrus-sasl-devel gtk-doc<br class="gmail_msg">
diff --git a/autogen.sh b/autogen.sh<br class="gmail_msg">
index da28eef..cc7bda3 100755<br class="gmail_msg">
--- a/autogen.sh<br class="gmail_msg">
+++ b/autogen.sh<br class="gmail_msg">
@@ -10,7 +10,6 @@ test -z "$srcdir" && srcdir=.<br class="gmail_msg">
git submodule update --init --recursive<br class="gmail_msg">
gtkdocize<br class="gmail_msg">
autoreconf -v --force --install<br class="gmail_msg">
- intltoolize -f<br class="gmail_msg">
)<br class="gmail_msg">
<br class="gmail_msg">
CONFIGURE_ARGS="--enable-maintainer-mode --enable-gtk-doc --with-gtk=3.0 --enable-vala"<br class="gmail_msg">
diff --git a/<a href="http://configure.ac" rel="noreferrer" class="gmail_msg" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" class="gmail_msg" target="_blank">configure.ac</a><br class="gmail_msg">
index ad5e6e9..e881822 100644<br class="gmail_msg">
--- a/<a href="http://configure.ac" rel="noreferrer" class="gmail_msg" target="_blank">configure.ac</a><br class="gmail_msg">
+++ b/<a href="http://configure.ac" rel="noreferrer" class="gmail_msg" target="_blank">configure.ac</a><br class="gmail_msg">
@@ -13,11 +13,11 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR])<br class="gmail_msg">
LT_INIT([disable-static win32-dll])<br class="gmail_msg">
AM_MAINTAINER_MODE<br class="gmail_msg">
<br class="gmail_msg">
-IT_PROG_INTLTOOL([0.40.0])<br class="gmail_msg">
-GETTEXT_PACKAGE=spice-gtk<br class="gmail_msg">
+GETTEXT_PACKAGE=AC_PACKAGE_TARNAME<br class="gmail_msg">
AC_SUBST(GETTEXT_PACKAGE)<br class="gmail_msg">
-AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE],"$GETTEXT_PACKAGE", [GETTEXT package name])<br class="gmail_msg">
-AM_GLIB_GNU_GETTEXT<br class="gmail_msg">
+AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE], "$GETTEXT_PACKAGE", [GETTEXT package name])<br class="gmail_msg">
+AM_GNU_GETTEXT_VERSION([0.19.8])<br class="gmail_msg">
+AM_GNU_GETTEXT([external])<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
SPICE_GTK_LOCALEDIR=[${datadir}/locale]<br class="gmail_msg">
diff --git a/po/Makevars b/po/Makevars<br class="gmail_msg">
new file mode 100644<br class="gmail_msg">
index 0000000..a8ab95e<br class="gmail_msg">
--- /dev/null<br class="gmail_msg">
+++ b/po/Makevars<br class="gmail_msg">
@@ -0,0 +1,76 @@<br class="gmail_msg">
+# Makefile variables for PO directory in any package using GNU gettext.<br class="gmail_msg">
+<br class="gmail_msg">
+# Usually the message domain is the same as the package name.<br class="gmail_msg">
+DOMAIN = $(GETTEXT_DOMAIN)<br class="gmail_msg">
+<br class="gmail_msg"></blockquote><div><br></div><div>It's not defined, $(PACKAGE) works better here.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+# These two variables depend on the location of this directory.<br class="gmail_msg">
+subdir = po<br class="gmail_msg">
+top_builddir = ..<br class="gmail_msg">
+<br class="gmail_msg">
+# These options get passed to xgettext.<br class="gmail_msg">
+XGETTEXT_OPTIONS = --keyword=_ --keyword=N_ \<br class="gmail_msg">
+ --keyword=C_:1c,2 --keyword=NC_:1c,2 \<br class="gmail_msg">
+ --keyword=g_dngettext:2,3 \<br class="gmail_msg">
+ --flag=g_dngettext:2:pass-c-format \<br class="gmail_msg">
+ --flag=g_strdup_printf:1:c-format \<br class="gmail_msg">
+ --flag=g_string_printf:2:c-format \<br class="gmail_msg">
+ --flag=g_string_append_printf:2:c-format \<br class="gmail_msg">
+ --flag=g_error_new:3:c-format \<br class="gmail_msg">
+ --flag=g_set_error:4:c-format \<br class="gmail_msg">
+ --flag=g_markup_printf_escaped:1:c-format \<br class="gmail_msg">
+ --flag=g_log:3:c-format \<br class="gmail_msg">
+ --flag=g_print:1:c-format \<br class="gmail_msg">
+ --flag=g_printerr:1:c-format \<br class="gmail_msg">
+ --flag=g_printf:1:c-format \<br class="gmail_msg">
+ --flag=g_fprintf:2:c-format \<br class="gmail_msg">
+ --flag=g_sprintf:2:c-format \<br class="gmail_msg">
+ --flag=g_snprintf:3:c-format<br class="gmail_msg">
+<br class="gmail_msg">
+<br class="gmail_msg">
+# This is the copyright holder that gets inserted into the header of the<br class="gmail_msg">
+# $(DOMAIN).pot file. Set this to the copyright holder of the surrounding<br class="gmail_msg">
+# package. (Note that the msgstr strings, extracted from the package's<br class="gmail_msg">
+# sources, belong to the copyright holder of the package.) Translators are<br class="gmail_msg">
+# expected to transfer the copyright for their translations to this person<br class="gmail_msg">
+# or entity, or to disclaim their copyright. The empty string stands for<br class="gmail_msg">
+# the public domain; in this case the translators are expected to disclaim<br class="gmail_msg">
+# their copyright.<br class="gmail_msg">
+COPYRIGHT_HOLDER = Free Software Foundation, Inc.<br class="gmail_msg">
+<br class="gmail_msg">
+# This tells whether or not to prepend "GNU " prefix to the package<br class="gmail_msg">
+# name that gets inserted into the header of the $(DOMAIN).pot file.<br class="gmail_msg">
+# Possible values are "yes", "no", or empty. If it is empty, try to<br class="gmail_msg">
+# detect it automatically by scanning the files in $(top_srcdir) for<br class="gmail_msg">
+# "GNU packagename" string.<br class="gmail_msg">
+PACKAGE_GNU = no<br class="gmail_msg">
+<br class="gmail_msg">
+# This is the email address or URL to which the translators shall report<br class="gmail_msg">
+# bugs in the untranslated strings:<br class="gmail_msg">
+# - Strings which are not entire sentences, see the maintainer guidelines<br class="gmail_msg">
+# in the GNU gettext documentation, section 'Preparing Strings'.<br class="gmail_msg">
+# - Strings which use unclear terms or require additional context to be<br class="gmail_msg">
+# understood.<br class="gmail_msg">
+# - Strings which make invalid assumptions about notation of date, time or<br class="gmail_msg">
+# money.<br class="gmail_msg">
+# - Pluralisation problems.<br class="gmail_msg">
+# - Incorrect English spelling.<br class="gmail_msg">
+# - Incorrect formatting.<br class="gmail_msg">
+# It can be your email address, or a mailing list address where translators<br class="gmail_msg">
+# can write to without being subscribed, or the URL of a web page through<br class="gmail_msg">
+# which the translators can contact you.<br class="gmail_msg">
+MSGID_BUGS_ADDRESS =<br class="gmail_msg">
+<br class="gmail_msg">
+# This is the list of locale categories, beyond LC_MESSAGES, for which the<br class="gmail_msg">
+# message catalogs shall be used. It is usually empty.<br class="gmail_msg">
+EXTRA_LOCALE_CATEGORIES =<br class="gmail_msg">
+<br class="gmail_msg">
+# Ignore the timestamp of the .pot file, as git clones do not have<br class="gmail_msg">
+# deterministic timestamps, and .po files are updated by translators<br class="gmail_msg">
+# (only) in GNOME projects.<br class="gmail_msg">
+PO_DEPENDS_ON_POT = no<br class="gmail_msg">
+<br class="gmail_msg">
+# This tells whether or not to forcibly update $(DOMAIN).pot and<br class="gmail_msg">
+# regenerate PO files on "make dist". Possible values are "yes" and<br class="gmail_msg">
+# "no". Set this to no if the POT file and PO files are maintained<br class="gmail_msg">
+# externally.<br class="gmail_msg">
+DIST_DEPENDS_ON_UPDATE_PO = no<br class="gmail_msg">
--<br class="gmail_msg">
2.12.0.191.gc5d8de91d<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
Spice-devel mailing list<br class="gmail_msg">
<a href="mailto:Spice-devel@lists.freedesktop.org" class="gmail_msg" target="_blank">Spice-devel@lists.freedesktop.org</a><br class="gmail_msg">
<a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br class="gmail_msg">
</blockquote></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Marc-André Lureau<br></div></div>