<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 11 May 2017, at 11:17, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><div class=""><div class="">...<br class=""></div></div><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div class=""><br class=""><blockquote class=""><div class=""><div style="" class=""><blockquote style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote class=""><br class=""><blockquote class=""> g_array_set_size(c->remote_common_caps, num_common_caps);<br class=""> for (i = 0; i < num_common_caps; i++, caps++) {<br class=""></blockquote><br class=""></blockquote></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">I cannot find these macros defined in spice-gtk. Where are they?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></div></blockquote><div class=""><br class=""></div><div class="">spice-common. I think I announced it in the envelope mail for the patch. That’s why there is a submodule update. I don’t know if this is the right way to do things for submodule required changes.</div></div></blockquote><div class="">You should send the changeset with spice-common with the other changesets (so the mail to the ML).</div></div></div></div></blockquote><div><br class=""></div><div>You mean I should add a link for example <a href="https://lists.freedesktop.org/archives/spice-devel/2017-May/037505.html" class="">https://lists.freedesktop.org/archives/spice-devel/2017-May/037505.html</a> to the description? Or make a single patch set with changes both in spice-common and spice-gtk. If the latter, I don’t know how…</div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><div class=""> Also the spice-gtk changes should include a change to spice-common submodule.<br class=""></div></div></div></div></blockquote><div><br class=""></div><div>I see it in <a href="https://lists.freedesktop.org/archives/spice-devel/2017-May/037509.html:" class="">https://lists.freedesktop.org/archives/spice-devel/2017-May/037509.html:</a></div><div><br class=""></div><div><pre style="white-space: pre-wrap; background-color: rgb(255, 255, 255);" class="">diff --git a/spice-common b/spice-common
index af682b1..1239c82 160000
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject commit af682b1b06dea55007d9aa7c37cd443e4349e43f
+Subproject commit 1239c82c54dee0244cca262cca0aa21071b23e24
</pre><div class="">Or do you mean something else?</div><div class=""><br class=""></div><div class="">(BTW, I sent an updated series with your comments, still not showing up, so I guess my mail setup is still not good enough)</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Thanks</div><div class="">Christophe</div></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div class=""><div style="font-family: 'times new roman', 'new york', times, serif; font-size: 12pt;" class=""><div class=""><br class=""></div><div class="">Frediano<br class=""></div><div class=""><br class=""></div></div></div></div></blockquote></div><br class=""></body></html>