<div dir="ltr"><div><div>Hi,</div>I copied the message concerning VD_AGENT_FILE_XFER_STATUS_NO_AGENT from the linux vdagent. What message would you suggest instead? Perhaps something like "Agent not connected, file-xfer cancelled."?<br></div>Thanks<br></div><br><div class="gmail_quote"><div dir="ltr">On Mon, May 29, 2017 at 12:17 PM Christophe Fergeau <<a href="mailto:cfergeau@redhat.com">cfergeau@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sun, May 28, 2017 at 11:36:34PM +0200, Jakub Janků wrote:<br>
> Log appropriate error messages when we receive<br>
> VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED or<br>
> VD_AGENT_FILE_XFER_STATUS_NO_AGENT.<br>
> ---<br>
>  src/channel-main.c | 10 ++++++++++<br>
>  1 file changed, 10 insertions(+)<br>
><br>
> diff --git a/src/channel-main.c b/src/channel-main.c<br>
> index af1350c..2a53a3f 100644<br>
> --- a/src/channel-main.c<br>
> +++ b/src/channel-main.c<br>
> @@ -1882,6 +1882,16 @@ static void main_agent_handle_xfer_status(SpiceMainChannel *channel,<br>
>          g_free(file_size_str);<br>
>          break;<br>
>      }<br>
> +    case VD_AGENT_FILE_XFER_STATUS_SESSION_LOCKED:<br>
> +        error = g_error_new_literal(SPICE_CLIENT_ERROR, SPICE_CLIENT_ERROR_FAILED,<br>
> +                                    _("User's session is locked and cannot transfer files, "<br>
> +                                      "unlock and try again."));<br>
<br>
unlock it and try again<br>
<br>
> +        break;<br>
> +    case VD_AGENT_FILE_XFER_STATUS_NO_AGENT:<br>
> +        error = g_error_new_literal(SPICE_CLIENT_ERROR, SPICE_CLIENT_ERROR_FAILED,<br>
> +                                    _("Could not find an agent connection belonging to the "<br>
> +                                      "active session, file-xfer cancelled."));<br>
<br>
Is this meant to be shown to the user? If yes, I don't think this is<br>
a very clear message for someone not really familiar with how file<br>
transfer works.<br>
<br>
Christophe<br>
</blockquote></div>