<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 8 Jun 2017, at 12:18, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class="">From: Christophe de Dinechin <<a href="mailto:dinechin@redhat.com" class="">dinechin@redhat.com</a>><br class=""><br class="">On macOS, neither of the two cases implemented in set_mouse_accel applies.<br class="">We get the following eror message:<br class=""><br class=""> CC spice-widget.lo<br class="">spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable]<br class=""> SpiceDisplayPrivate *d = display->priv;<br class=""><br class="">Signed-off-by: Christophe de Dinechin <<a href="mailto:dinechin@redhat.com" class="">dinechin@redhat.com</a>><br class="">---<br class="">src/spice-widget.c | 7 ++++---<br class="">1 file changed, 4 insertions(+), 3 deletions(-)<br class=""><br class="">diff --git a/src/spice-widget.c b/src/spice-widget.c<br class="">index 1a1d5a6..a2f3e30 100644<br class="">--- a/src/spice-widget.c<br class="">+++ b/src/spice-widget.c<br class="">@@ -941,9 +941,8 @@ static void update_keyboard_grab(SpiceDisplay *display)<br class=""><br class="">static void set_mouse_accel(SpiceDisplay *display, gboolean enabled)<br class="">{<br class="">- SpiceDisplayPrivate *d = display->priv;<br class="">-<br class="">#if defined GDK_WINDOWING_X11<br class="">+ SpiceDisplayPrivate *d = display->priv;<br class=""> GdkWindow *w = GDK_WINDOW(gtk_widget_get_window(GTK_WIDGET(display)));<br class=""><br class=""> if (!GDK_IS_X11_DISPLAY(gdk_window_get_display(w))) {<br class="">@@ -965,6 +964,7 @@ static void set_mouse_accel(SpiceDisplay *display,<br class="">gboolean enabled)<br class=""> d->x11_accel_numerator, d->x11_accel_denominator,<br class=""> d->x11_threshold);<br class=""> }<br class="">#elif defined GDK_WINDOWING_WIN32<br class="">+ SpiceDisplayPrivate *d = display->priv;<br class=""> if (enabled) {<br class=""> g_return_if_fail(SystemParametersInfo(SPI_SETMOUSE, 0,<br class=""> &d->win_mouse, 0));<br class=""> g_return_if_fail(SystemParametersInfo(SPI_SETMOUSESPEED, 0,<br class=""> (PVOID)(INT_PTR)d->win_mouse_speed, 0));<br class="">@@ -976,6 +976,7 @@ static void set_mouse_accel(SpiceDisplay *display,<br class="">gboolean enabled)<br class=""> g_return_if_fail(SystemParametersInfo(SPI_SETMOUSESPEED, 0,<br class=""> (PVOID)10, SPIF_SENDCHANGE)); // default<br class=""> }<br class="">#else<br class="">+ /* TODO: Add mouse accelaration for macOS */<br class=""> g_warning("Mouse acceleration code missing for your platform");<br class="">#endif<br class="">}<br class="">@@ -1616,7 +1617,7 @@ static gboolean key_event(GtkWidget *widget,<br class="">GdkEventKey *key)<br class=""><br class=""> if (key->keyval == GDK_KEY_Pause<br class="">#ifdef G_OS_WIN32<br class="">- /* for some reason GDK does not fill keyval for VK_PAUSE<br class="">+ /* for some reason GDK does not fill keyval for VK_PAUSE<br class=""> * See <a href="https://bugzilla.gnome.org/show_bug.cgi?id=769214" class="">https://bugzilla.gnome.org/show_bug.cgi?id=769214</a><br class=""> */<br class=""> || key->hardware_keycode == VK_PAUSE<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Please remove this hunk</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></div></blockquote><div><br class=""></div><div>Emacs configured to remove trailing spaces automatically. Will make it a separate patch then.</div><div><br class=""></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div style="" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Other than that</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Acked</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></div></blockquote><div><br class=""></div><div>The series, or just this one?</div><br class=""><blockquote type="cite" class=""><div class=""><div style="" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Frediano</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Spice-devel mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:Spice-devel@lists.freedesktop.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Spice-devel@lists.freedesktop.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a></div></div></blockquote></div><br class=""></body></html>