<div dir="ltr">Hi<br><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 13, 2017 at 5:56 PM Jonathon Jongsma <<a href="mailto:jjongsma@redhat.com">jjongsma@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, 2017-06-13 at 16:53 +0200, Victor Toso wrote:<br>
> Hi,<br>
><br>
> On Tue, Jun 13, 2017 at 03:47:52PM +0100, Frediano Ziglio wrote:<br>
> > Following log discussion and Victor suggestion about removing<br>
> > these variable as already enough obsolete and documented<br>
> > proposed a patch to remove them.<br>
> > Mainly to get some consent and votes.<br>
<br>
Also note that these env variables (or at least the DEBUG_LEVEL one)<br>
only ever worked (partially) on spice-server, and not on spice-gtk,<br>
since it only enabled logging for the "Spice" domain.<br>
<br>
><br>
> +1, it would remove good amount of changes from Marc-André first<br>
> patch.<br>
> Did not test it yet ;)<br></blockquote><div><br><br></div><div>What's the plan? can we move ahead and remove those environment variables or delay ? until when ?<br><br></div><div>I think those variables create more confusion than help and are mostly there for legacy reasons, so I vote for removing them asap.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> ><br>
> > Frediano Ziglio (2):<br>
> >   log: remove deprecated SPICE_ABORT_LEVEL support<br>
> >   log: remove deprecated SPICE_DEBUG_LEVEL support<br>
> ><br>
> >  common/log.c         | 107 +------------------------------------<br>
> > --------------<br>
> >  tests/test-logging.c |  95 -------------------------------------<br>
> > --------<br>
> >  2 files changed, 1 insertion(+), 201 deletions(-)<br>
> ><br>
> > -- <br>
> > 2.9.4<br>
> ><br>
> > _______________________________________________<br>
> > Spice-devel mailing list<br>
> > <a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.org</a><br>
> > <a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
><br>
> _______________________________________________<br>
> Spice-devel mailing list<br>
> <a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
_______________________________________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org" target="_blank">Spice-devel@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/spice-devel</a><br>
</blockquote></div></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr">Marc-André Lureau<br></div></div>