<div dir="ltr">Hi, sure. I'll change it to <span style="font-size:12.8px">'==='</span><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">(I think in this case it does not matter - it's comparing ints not objects, but as you said, we should be consistent)</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 20, 2017 at 10:44 PM, Jeremy White <span dir="ltr"><<a href="mailto:jwhite@codeweavers.com" target="_blank">jwhite@codeweavers.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
One tiny niggle:<br>
<span class=""><br>
On 06/08/2017 09:27 AM, Pavel Grunt wrote:<br>
> @@ -606,7 +607,8 @@ SpiceDisplayConn.prototype.<wbr>process_channel_message = function(msg)<br>
>          if (this.streams[<a href="http://m.base.id" rel="noreferrer" target="_blank">m.base.id</a>].<wbr>codec_type === SPICE_VIDEO_CODEC_TYPE_MJPEG)<br>
>              process_mjpeg_stream_data(<wbr>this, m, time_until_due);<br>
><br>
> -        if (this.streams[<a href="http://m.base.id" rel="noreferrer" target="_blank">m.base.id</a>].<wbr>codec_type === SPICE_VIDEO_CODEC_TYPE_VP8)<br>
> +        if (this.streams[<a href="http://m.base.id" rel="noreferrer" target="_blank">m.base.id</a>].<wbr>codec_type === SPICE_VIDEO_CODEC_TYPE_VP8 ||<br>
> +            this.streams[<a href="http://m.base.id" rel="noreferrer" target="_blank">m.base.id</a>].codec_<wbr>type == SPICE_VIDEO_CODEC_TYPE_VP9)<br>
>              process_video_stream_data(<wbr>this.streams[<a href="http://m.base.id" rel="noreferrer" target="_blank">m.base.id</a>], m);<br>
><br>
>          return true;<br>
<br>
</span>The original author of this code did a poor job of deciding whether or<br>
not to use '===' everywhere or whether to use '=='.  There appears to be<br>
some debate, with the consensus being that '===' is often more<br>
appropriate.  Sadly, this code base mixes the two, and mostly uses '=='.<br>
<br>
I'd ask that this if statement be at least internally consistent.  I<br>
don't know that it is clear to me whether it should be '==' or '==='.<br>
<br>
Cheers,<br>
<br>
Jeremy<br>
<div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/spice-devel</a><br>
</div></div></blockquote></div><br></div>