<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 7, 2017 at 2:38 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">><br>
> Add ability to produce ETW (Event Tracing for Windows) to release<br>
> version of the driver to be able to record binary traces in case<br>
> of problem in customer environment for further analysis.<br>
> Logging of debug build is not changed.<br>
><br>
<br>
</span>Why you decided to not change debug build?<br></blockquote><div><br></div><div>The goal is not completely replace debugview with ETW, but be able to collect logs in the field.</div><div>After the release will use ETW, we can discuss who wants debug version to be ETW-ed and who not.</div><div>I'm not, as currently there is no easy tool to work with ETW online (and with debug I prefer online).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Frediano<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> Signed-off-by: Yuri Benditovich <<a href="mailto:yuri.benditovich@daynix.com">yuri.benditovich@daynix.com</a>><br>
> ---<br>
>  qxldod/QxlDod.cpp     | 3 +++<br>
>  qxldod/driver.cpp     | 6 ++++++<br>
>  qxldod/driver.h       | 2 +-<br>
>  qxldod/qxldod.vcxproj | 5 +++++<br>
>  4 files changed, 15 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp<br>
> index b97301a..4f508bd 100755<br>
> --- a/qxldod/QxlDod.cpp<br>
> +++ b/qxldod/QxlDod.cpp<br>
> @@ -12,6 +12,9 @@<br>
>  #include "qxldod.h"<br>
>  #include "qxl_windows.h"<br>
>  #include "compat.h"<br>
> +#if !DBG<br>
> +#include "qxldod.tmh"<br>
> +#endif<br>
><br>
>  #pragma code_seg("PAGE")<br>
><br>
> diff --git a/qxldod/driver.cpp b/qxldod/driver.cpp<br>
> index 1ff2abb..aa245c8 100755<br>
> --- a/qxldod/driver.cpp<br>
> +++ b/qxldod/driver.cpp<br>
> @@ -10,6 +10,9 @@<br>
><br>
>  #include "driver.h"<br>
>  #include "QxlDod.h"<br>
> +#if !DBG<br>
> +#include "driver.tmh"<br>
> +#endif<br>
><br>
>  #pragma code_seg(push)<br>
>  #pragma code_seg("INIT")<br>
> @@ -62,6 +65,8 @@ DriverEntry(<br>
>  {<br>
>      PAGED_CODE();<br>
><br>
> +    WPP_INIT_TRACING(NULL, NULL);<br>
> +<br>
>      DbgPrint(TRACE_LEVEL_FATAL, ("---> KMDOD build on on %s %s\n", __DATE__,<br>
>      __TIME__));<br>
><br>
>      RTL_OSVERSIONINFOW versionInfo;<br>
> @@ -157,6 +162,7 @@ DodUnload(VOID)<br>
>  {<br>
>      PAGED_CODE();<br>
>      DbgPrint(TRACE_LEVEL_<wbr>INFORMATION, ("<--> %s\n", __FUNCTION__));<br>
> +    WPP_CLEANUP(NULL);<br>
>  }<br>
><br>
>  NTSTATUS<br>
> diff --git a/qxldod/driver.h b/qxldod/driver.h<br>
> index a70b0e7..df5fb9f 100755<br>
> --- a/qxldod/driver.h<br>
> +++ b/qxldod/driver.h<br>
> @@ -10,7 +10,7 @@<br>
><br>
>  #pragma once<br>
>  #include "BaseObject.h"<br>
> -<br>
> +#include "WppTrace.h"<br>
><br>
>  extern "C"<br>
>  DRIVER_INITIALIZE DriverEntry;<br>
> diff --git a/qxldod/qxldod.vcxproj b/qxldod/qxldod.vcxproj<br>
> index 1766a61..15e36d9 100755<br>
> --- a/qxldod/qxldod.vcxproj<br>
> +++ b/qxldod/qxldod.vcxproj<br>
> @@ -185,6 +185,8 @@<br>
>      <ClCompile><br>
>        <AdditionalIncludeDirectories><wbr>%(<wbr>AdditionalIncludeDirectories);<wbr>$(DDK_INC_PATH);$(SDK_INC_<wbr>PATH);.\Include</<wbr>AdditionalIncludeDirectories><br>
>        <WarningLevel>Level3</<wbr>WarningLevel><br>
> +      <WppScanConfigurationData><wbr>WppTrace.h</<wbr>WppScanConfigurationData><br>
> +      <WppEnabled>true</WppEnabled><br>
>      </ClCompile><br>
>      <PostBuildEvent><br>
>        <Command>Inf2Cat /driver:$(OutDir) /os:8_X86,6_3_X86</Command><br>
> @@ -255,6 +257,8 @@<br>
>      <ClCompile><br>
>        <AdditionalIncludeDirectories><wbr>%(<wbr>AdditionalIncludeDirectories);<wbr>$(DDK_INC_PATH);$(SDK_INC_<wbr>PATH);.\Include</<wbr>AdditionalIncludeDirectories><br>
>        <WarningLevel>Level3</<wbr>WarningLevel><br>
> +      <WppScanConfigurationData><wbr>WppTrace.h</<wbr>WppScanConfigurationData><br>
> +      <WppEnabled>true</WppEnabled><br>
>      </ClCompile><br>
>      <PostBuildEvent><br>
>        <Command>Inf2Cat /driver:$(OutDir)<br>
>        /os:8_X64,Server8_X64,Server6_<wbr>3_X64,6_3_X64</Command><br>
> @@ -277,6 +281,7 @@<br>
>      <ClInclude Include="driver.h" /><br>
>      <ClInclude Include="QxlDod.h" /><br>
>      <ClInclude Include="resource.h" /><br>
> +    <ClInclude Include="WppTrace.h" /><br>
>    </ItemGroup><br>
>    <ItemGroup><br>
>      <ClCompile Include="BaseObject.cpp" /><br>
<br>
</div></div></blockquote></div><br></div></div>