<div dir="ltr">Hi Jeremy,<div><br></div><div>I will fix it and yes, we can just add condition to unhandled errors.</div><div><br></div><div>Tomáš</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-09-15 20:18 GMT+02:00 Jeremy White <span dir="ltr"><<a href="mailto:jwhite@codeweavers.com" target="_blank">jwhite@codeweavers.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Tomáš,<br>
<div><div class="h5"><br>
<br>
On 09/06/2017 03:52 AM, Tomáš Bohdálek wrote:<br>
> ---<br>
>  main.js         | 15 +++++++++++++++<br>
>  spice.html      |  5 +++++<br>
>  spice_auto.html |  5 +++++<br>
>  3 files changed, 25 insertions(+)<br>
><br>
> diff --git a/main.js b/main.js<br>
> index 0237f0e..447177b 100644<br>
> --- a/main.js<br>
> +++ b/main.js<br>
> @@ -385,20 +385,25 @@ SpiceMainConn.prototype.<wbr>handle_file_xfer_status = function(file_xfer_status)<br>
>              break;<br>
>          case VD_AGENT_FILE_XFER_STATUS_<wbr>ERROR:<br>
>              xfer_error = "some errors occurred in the spice agent";<br>
> +            this.file_xfer_detailed_<wbr>errors(xfer_error);<br>
>              break;<br>
>          case VD_AGENT_FILE_XFER_STATUS_<wbr>SUCCESS:<br>
>              break;<br>
>          case VD_AGENT_FILE_XFER_STATUS_NOT_<wbr>ENOUGH_SPACE:<br>
>              xfer_error = "not enough space in the remote system";<br>
> +            this.file_xfer_detailed_<wbr>errors(xfer_error);<br>
>              break;<br>
>          case VD_AGENT_FILE_XFER_STATUS_<wbr>SESSION_LOCKED:<br>
>              xfer_error = "remote system is locked";<br>
> +            this.file_xfer_detailed_<wbr>errors(xfer_error);<br>
>              break;<br>
>          case VD_AGENT_FILE_XFER_STATUS_<wbr>AGENT_NOT_CONNECTED:<br>
>              xfer_error = "spice angent is not connected";<br>
<br>
</div></div>Mind fixing this typo when you get a second?<br>
<span class=""><br>
> +            this.file_xfer_detailed_<wbr>errors(xfer_error);<br>
>              break;<br>
>          case VD_AGENT_FILE_XFER_STATUS_<wbr>DISABLED:<br>
>              xfer_error = "file transfer is disabled on the remote system";<br>
> +            this.file_xfer_detailed_<wbr>errors(xfer_error);<br>
>              break;<br>
>          default:<br>
>              xfer_error = "unhandled status type: " + file_xfer_status.result;<br>
> @@ -506,3 +511,13 @@ SpiceMainConn.prototype.<wbr>relative_now = function()<br>
>      var ret = (Date.now() - this.our_mm_time) + this.mm_time;<br>
>      return ret;<br>
<br>
</span>Why not also alert for unhandled errors and for cases where the transfer<br>
was canceled by the agent?  In other words, why not just a:<br>
  if (file_xfer_status.result != VD_AGENT_FILE_XFER_STATUS_<wbr>SUCCESS)<br>
?<br>
<br>
Cheers,<br>
<br>
Jeremy<br>
<br>
______________________________<wbr>_________________<br>
Spice-devel mailing list<br>
<a href="mailto:Spice-devel@lists.freedesktop.org">Spice-devel@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/spice-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/spice-devel</a><br>
</blockquote></div><br></div>