<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><br></div><div class="gmail_quote"><div dir="ltr">On Fri, Oct 20, 2017, 1:40 PM Frediano Ziglio <<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">><br> > This is required for the following GMainLoop integration,<br> > which utilizes some of the new functions/definitions, namely:<br> ><br> > [definition][GLib version]<br> > g_clear_pointer() 2.34<br> > G_SOURCE_REMOVE 2.32<br> > G_SOURCE_CONTINUE 2.32<br> > g_unix_signal_add() 2.30<br> ><br> > GLib version accross distributions:<br> > - Fedora 26 2.52<br> > - Fedora 25 2.50<br> > - Fedora 24 2.48<br> > - CentOS 7 2.46<br> > - Debian 9 2.50<br> ><br> > RHEL 6 is no longer supported,<br> > so remove README.RHEL-5.<br> ><br> > Acked-by: Frediano Ziglio <<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>><br><br> Still ack.<br><br> Are you fine with the series or do you prefer the g_idle change?<br></blockquote></div><div><br></div><div>Yeah, I'm totally fine with it.</div><div><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I'm fine your yours/Victor patches, just need an ack to mine.<br></blockquote></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Great, so are we waiting for someone else from the spice team to ack your patch?</span></div></blockquote><div>For me your is fine too.<br></div><div><br></div><div>Frediano<br></div><div><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br> Frediano<br></blockquote></div><div><br></div><div>Thanks,</div><div>Jakub</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br> > ---<br> > Makefile.am | 1 -<br> > README.RHEL-5 | 34 ----------------------------------<br> > <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 2 +-<br> > 3 files changed, 1 insertion(+), 36 deletions(-)<br> > delete mode 100644 README.RHEL-5<br> ><br> > diff --git a/Makefile.am b/Makefile.am<br> > index 45f7177..4689713 100644<br> > --- a/Makefile.am<br> > +++ b/Makefile.am<br> > @@ -121,7 +121,6 @@ manpage_DATA = \<br> ><br> > EXTRA_DIST = \<br> > NEWS \<br> > - README.RHEL-5 \<br> > data/70-spice-vdagentd.rules \<br> > data/spice-vdagent.desktop \<br> > data/spice-vdagentd \<br> > diff --git a/README.RHEL-5 b/README.RHEL-5<br> > deleted file mode 100644<br> > index 9b9ccc7..0000000<br> > --- a/README.RHEL-5<br> > +++ /dev/null<br> > @@ -1,34 +0,0 @@<br> > -spice-vdagent and RHEL-5 README<br> > --------------------------------<br> > -<br> > -spice-vdagent can also be used inside RHEL-5 guests, if, and only if, they<br> > -are hosted on a host which uses virtio-serial as the agent channel. Note<br> > -that older hosts, such as qemu shipped with RHEL-5 for example, use<br> > -a custom pci device (the spicevmc device) for the agent channel and<br> > -there is no Linux support for this device so spice-vdagent does not work<br> > -inside guests hosted on such hosts! Hosts based on RHEL-6 or Fedora 15<br> > -and newer for example, are fine.<br> > -<br> > -spice-vdagent relies on ConsoleKit to determine the active session, since<br> > -RHEL-5 has no ConsoleKit it cannot do this on RHEL-5, therefor only 1<br> > -active X-session is supported with RHEL-5. If you try to start multiple<br> > -sessions by running multiple X-servers the agent will disable itself.<br> > -<br> > -Since the RHEL-5 X-server does not support hotplugging of input devices,<br> > -spice-vdagentd must be started before the X-server, so that it can create<br> > -the uinput tablet device it uses for agent mouse mode.<br> > -<br> > -This also means that you must use a customized xorg.conf to teach the<br> > -X-server about the uinput device. An example xorg.conf is included with<br> > -spice-vdagent. After installing spice-vdagent, first start spice-vdagentd,<br> > -and then copy this file to /etc/X11/xorg.conf and restart your X-server.<br> > -<br> > -Note: the sample xorg.conf assumes that the vm has been configured to *not*<br> > -use a usb tablet device, since there is no need for one with the agent and<br> > -usb emulation takes a significant amount of CPU.<br> > -<br> > -Building from source for RHEL-5<br> > --------------------------------<br> > -<br> > -If you're building spice-vdagent from source on RHEL-5, you must pass<br> > ---disable-console-kit --enable-static-uinput to ./configure!<br> > diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> > index fbc20a9..d92b527 100644<br> > --- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> > +++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> > @@ -85,7 +85,7 @@ AC_ARG_ENABLE([static-uinput],<br> > [enable_static_uinput="$enableval"],<br> > [enable_static_uinput="no"])<br> ><br> > -PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.28])<br> > +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.34])<br> > PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])<br> > PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.13])<br> > PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22])<br></blockquote></div></blockquote><div><br></div></div></body></html>