<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div>On 14 Nov 2017, at 16:57, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="" target="_blank">fziglio@redhat.com</a>> wrote:<blockquote class=""><br class="Apple-interchange-newline"><div class=""><div style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; font-family: "times new roman", "new york", times, serif; font-size: 12pt;" class=""><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div class=""><blockquote class=""><div class=""><br class="Apple-interchange-newline">On 14 Nov 2017, at 16:22, Frediano Ziglio <<a href="mailto:fziglio@redhat.com" class="" target="_blank">fziglio@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><blockquote class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="">From: Christophe de Dinechin <<a href="mailto:dinechin@redhat.com" class="" target="_blank">dinechin@redhat.com</a>><br class=""><br class="">Signed-off-by: Christophe de Dinechin <<a href="mailto:dinechin@redhat.com" class="" target="_blank">dinechin@redhat.com</a>><br class="">---<br class="">include/spice-streaming-agent/plugin.hpp | 2 +-<br class="">1 file changed, 1 insertion(+), 1 deletion(-)<br class=""><br class="">diff --git a/include/spice-streaming-agent/plugin.hpp<br class="">b/include/spice-streaming-agent/plugin.hpp<br class="">index 727cb3b..607fabf 100644<br class="">--- a/include/spice-streaming-agent/plugin.hpp<br class="">+++ b/include/spice-streaming-agent/plugin.hpp<br class="">@@ -26,7 +26,7 @@ class FrameCapture;<br class=""> * where MM is major and mm is the minor, can be easily expanded<br class=""> * using more bits in the future<br class=""> */<br class="">-enum Constants : unsigned { PluginVersion = 0x100u };<br class="">+enum Constants : unsigned { PluginVersion = 0x001u };<br class=""><br class="">enum Ranks : unsigned {<br class=""> /// this plugin should not be used<br class=""></blockquote><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Nack... ABI not compatible</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></div></div></blockquote><div class=""><br class=""></div><div class="">Precisely. We should not have started at 1.0. I think it’s still time to fix it.</div><div class=""><br class=""></div><div class="">Christophe</div></div></blockquote><div class="">Going backward? Would not be easier to get to 1.1 instead?<br class=""></div><div class="">Also 0x1 does not fit with the comment above.<br class=""></div></div></div></blockquote><div><br class=""></div><div>Yes. I think that what we build presently should be labelled as 0.01, not 1.0.</div><div>Unless you consider this ABI / API to be good enough to be labelled 1.0,</div><div>which I do not, because it still lacks some very basic amenities.</div></div></blockquote><div>You acked 0x100 so now is quite too late to get back.<br></div><div>If you consider that not "fixed" we can keep the number, if we consider fixed<br></div><div>we'll bump it.<br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><div>Now, it’s only an internal number, so I don’t mind much going to 2.0 instead</div><div>if you prefer. It cannot be 1.1, because that would be seen as compatible.</div><div>But I thought 0.01 was fairer to the actual state of the API, while also</div><div>indicating a compatibility break.</div></div></blockquote><div>I would try to extend maintaining API/ABI if possible. As far as I can see<br></div><div>your mainly concerns are lack of some features.<br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><div>For an actual release, we can skip 1.0 if we fear there is any risk because</div><div>at some point we used 1.0.</div></div></blockquote><div>Frediano<br></div></div></body></html>