<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 9, 2018 at 10:09 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><span class="gmail-"><br>
<br>
> Hello!<br>
<br>
> I would really like to see XSpice and xf86-video-qxl on FreeBSD.<br>
<br>
> The correction for the FreeBSD build libspice-server.so is quite trivial and<br>
> mechanical (first and dirty version in attach. I'd like to do the FreeBSD<br>
> port later)<br>
<br>
</span>About the patch:<br>
<br>
<br>
--- server/net-utils.c.orig     2017-09-12 15:00:11.000000000 +0300<br>
+++ server/net-utils.c  2017-12-27 17:40:47.728516000 +0300<br>
@@ -23,6 +23,9 @@<br>
 #include <fcntl.h><br>
 #include <stdbool.h><br>
 #include <string.h><br>
+#include <sys/types.h><br>
+#include <arpa/inet.h><br>
+#include <netinet/in.h><br>
 #include <netinet/ip.h><br>
 #include <netinet/tcp.h><br>
 #include <sys/socket.h><br>
@@ -42,7 +45,7 @@<br>
 {<br>
     int keepalive = !!enable;<br>
<br>
-    if (setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, &keepalive, sizeof(keepalive)) == -1) {<br>
+    if (setsockopt(fd, IPPROTO_TCP, SO_KEEPALIVE, &keepalive, sizeof(keepalive)) == -1) {<br>
         if (errno != ENOTSUP) {<br>
             spice_printerr("setsockopt for keepalive failed, %s", strerror(errno));<br>
             return false;<br>
<br>
<br>
no, this should be SOL_SOCKET as documented also in FreeBSD documentation.<br>
<br>
<br></div>
//skipped//<br></blockquote><div><br></div><div><br></div><div><div class="gmail-gt-baf-cell"><span class="gmail-gt-baf-word-clickable">Oops!</span><span class="gmail-gt-baf-back"> </span><span id="gmail-result_box" class="gmail-" tabindex="-1" lang="en"><span>It's my fault.</span> <span class="gmail-">It seems that this was the cause of the problem</span></span><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span class="gmail-">. Now spice/qxl works on FreeBSD as expected: </span></span><br><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"></span><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span class="gmail-"><a href="https://snag.gy/4LSavc.jpg">https://snag.gy/4LSavc.jpg</a></span></span><span id="gmail-result_box" class="gmail-" tabindex="-1" lang="en"><span class="gmail-"></span></span><br><span id="gmail-result_box" class="gmail-" tabindex="-1" lang="en"><span class="gmail-"></span></span></div><span id="gmail-result_box" class="gmail-" tabindex="-1" lang="en"><span class="gmail-"><br></span><span class="gmail-">I've apply your other recommendations and after some testing I will submit a new </span><span class="gmail-">ports ( xf86-video-qxl, libspice-server )
 into the official FreeBSD ports tree and publish FreeBSD-specific fixes to this 
mailing list (in the hope that you can add it to the upstream)<br></span></span><span id="gmail-result_box" class="gmail-" tabindex="-1" lang="en"><span class="gmail-">Thank you very much for your help!</span></span></div><div><span id="gmail-result_box" class="gmail-" tabindex="-1" lang="en"><span class="gmail-"></span> <span class="gmail-"></span></span><br><span id="gmail-result_box" class="gmail-" tabindex="-1" lang="en"><span class="gmail-"></span></span></div></div></div></div>