<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On Wed, Jan 17, 2018 at 2:02 PM, Christophe Fergeau <<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">hey, On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote: > Confirm - these changes work successfully, tested on: FreeBSD 11.1-RELEASE > and FreeBSD 12-CURRENT (aka HEAD). > > Will these changes be included in the next release? > > There is another small issue of build libspice-server on FreeBSD > platform: OpenSSL > is included in the FreeBSD base. > However, the pkcconf does not find it without these changes: > > <a href="https://reviews.freebsd.org/D13896" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D13896</a> ( see head/devel/libspice-server/files/ > <a href="http://patch-configure.ac" rel="noreferrer" target="_blank">patch-configure.ac</a> ) > > Another way to fix it - install openssl from ports or packages ( while base > OpenSSL placed on /usr/lib and /usr/include, 3-rd packages and openssl from > ports/packages placed in /usr/local prefix and pkgconf finds it). > Nevertheless, at the moment there is no strong reason to add dependency for > OpenSSL from ports/packages. > > Can you review this patch for <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> ? I believe this patch can also > be useful for other platforms, including MacOSX. Perhaps it can also be > included in the upstream. Otherwise, it will remain in FreeBSD ports tree. Ah this is similar to <a href="https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=03d3ea2fa96566dfb413c7f53854390b089f9eed" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=03d3ea2fa96566dfb413c7f53854390b089f9eed</a> it can definitely be included upstream, though I'd prefer that both spice and spice-gtk does it the same way (both ways are fine with me, the patch you linked to probably saves one call to pkg-config). Christophe </blockquote></div> </div><div class="gmail_extra">Yea. There are several ways. Unfortunately, I do not know which one should be preferred.</div><div class="gmail_extra">Also, I am maintainer of spice-gtk port in FreeBSD and it also has similar fixes: <a href="https://svnweb.freebsd.org/ports/head/deskutils/spice-gtk/files/patch-configure.ac?revision=425018&view=markup">https://svnweb.freebsd.org/ports/head/deskutils/spice-gtk/files/patch-configure.ac?revision=425018&view=markup</a></div><div class="gmail_extra"> </div></div>