<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 17, 2018 at 2:18 PM, Oleg Ginzburg <span dir="ltr"><<a href="mailto:olevole@olevole.ru" target="_blank">olevole@olevole.ru</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div class="gmail-h5"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 17, 2018 at 2:02 PM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">hey,<br>
<span class="gmail-m_-7606742314181436607gmail-"><br>
On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote:<br>
> Confirm - these changes work successfully, tested on: FreeBSD 11.1-RELEASE<br>
> and FreeBSD 12-CURRENT (aka HEAD).<br>
><br>
> Will these changes be included in the next release?<br>
><br>
> There is another small issue of build libspice-server on FreeBSD<br>
> platform: OpenSSL<br>
> is included in the FreeBSD base.<br>
> However, the pkcconf does not find it without these changes:<br>
><br>
> <a href="https://reviews.freebsd.org/D13896" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D1<wbr>3896</a> ( see head/devel/libspice-server/fil<wbr>es/<br>
> <a href="http://patch-configure.ac" rel="noreferrer" target="_blank">patch-configure.ac</a> )<br>
><br>
> Another way to fix it - install openssl from ports or packages ( while base<br>
> OpenSSL placed on /usr/lib and /usr/include, 3-rd packages and openssl from<br>
> ports/packages placed in /usr/local prefix and pkgconf finds it).<br>
> Nevertheless, at the moment there is no strong reason to add dependency for<br>
> OpenSSL from ports/packages.<br>
><br>
> Can you review this patch for <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> ? I believe this patch can also<br>
> be useful for other platforms, including MacOSX. Perhaps it can also be<br>
> included in the upstream. Otherwise, it will remain in FreeBSD ports tree.<br>
<br>
</span>Ah this is similar to <a href="https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=03d3ea2fa96566dfb413c7f53854390b089f9eed" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/s<wbr>pice/spice-gtk/commit/?id=03d3<wbr>ea2fa96566dfb413c7f53854390b08<wbr>9f9eed</a><br>
it can definitely be included upstream, though I'd prefer that both<br>
spice and spice-gtk does it the same way (both ways are fine with me,<br>
the patch you linked to probably saves one call to pkg-config).<br>
<span class="gmail-m_-7606742314181436607gmail-HOEnZb"><font color="#888888"><br>
Christophe<br>
</font></span></blockquote></div><br></div></div></div><div class="gmail_extra">Yea. <span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-" lang="en"><span class="gmail-m_-7606742314181436607gmail-">There are several ways.</span> <span>Unfortunately, </span></span><span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-" lang="en"><span><span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-short_text" lang="en"><span class="gmail-m_-7606742314181436607gmail-">I do not know which one should be preferred.</span></span></span></span></div><div class="gmail_extra"><span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-" lang="en"><span>Also, </span></span><span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-short_text" lang="en"><span class="gmail-m_-7606742314181436607gmail-">I am maintainer of spice-gtk port in FreeBSD and </span></span><span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-short_text" lang="en"><span class="gmail-m_-7606742314181436607gmail-">it also has similar fixes:<br><br><a href="https://svnweb.freebsd.org/ports/head/deskutils/spice-gtk/files/patch-configure.ac?revision=425018&view=markup" target="_blank">https://svnweb.freebsd.org/<wbr>ports/head/deskutils/spice-<wbr>gtk/files/patch-configure.ac?<wbr>revision=425018&view=markup</a></span></span></div><div class="gmail_extra"><span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-short_text" lang="en"><span class="gmail-m_-7606742314181436607gmail-"></span></span><br><span id="gmail-m_-7606742314181436607gmail-result_box" class="gmail-m_-7606742314181436607gmail-" lang="en"><span></span></span></div></div>
</blockquote></div><br></div><div class="gmail_extra">Sorry, <span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span>I'm wrong, this patch is not for SSL. At the moment, spice-gtk port on FreeBSD use </span></span><span id="gmail-result_box" class="gmail-short_text" tabindex="-1" lang="en"><span>CONFIGURE_ENV to pass SSL_CFLAGS:<br><br><a href="https://svnweb.freebsd.org/ports/head/deskutils/spice-gtk/Makefile?revision=456217&view=markup#l37">https://svnweb.freebsd.org/ports/head/deskutils/spice-gtk/Makefile?revision=456217&view=markup#l37</a><br><br></span></span></div></div>