<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><blockquote style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre><blockquote style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><blockquote style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
The "max-bytes" property of the appsrc GStreamer element expects a
64-bit value. Calling:
g_object_set(source, "max-bytes", 0, NULL);
in a 32-bit architecture ends up with a wrong value, it must be cast to
a long long int:
g_object_set(source, "max-bytes", 0LL, NULL);
---
src/channel-display-gst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index f978602..c872a1f 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -333,7 +333,7 @@ static void app_source_setup(GstElement *pipeline
G_GNUC_UNUSED,
"caps", caps,
"is-live", TRUE,
"format", GST_FORMAT_TIME,
- "max-bytes", 0,
+ "max-bytes", 0LL,
"block", TRUE,
NULL);
gst_caps_unref(caps);
</blockquote>
I would use a gint64 cast instead.
Beside that patch is fine.
</blockquote>
Or even better G_GINT64_CONSTANT(0).
</pre></blockquote><div><br></div><div>Sure, didn't know about this macro. Do you want me to resend the modified patch?</div><div><br></div><div>Javier</div></blockquote><div>I was going to update the patch but I realized that the commit message is really bound</div><div> to "long long"syntax. Can you send an updated patch?<br></div><div><br></div><div>Frediano</div><div><br></div></div></body></html>