<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div><br></div><div dir="ltr">Hi Ziglio,<div><br></div><div>I was wondering if you have had a chance to look at the email below yet.</div><div><br></div><div><br></div><div>Best regards,</div><div>Zhongqiang Huang</div></div></blockquote><div>Yes, weird, usually git CC people in the commit message, but see<br></div><div><br></div><div><a href="https://lists.freedesktop.org/archives/spice-devel/2018-April/043230.html">https://lists.freedesktop.org/archives/spice-devel/2018-April/043230.html</a></div><div><br></div><div>this was acked and merged.<br></div><div><br></div><div>Christophe, should we backport to 0.12.8 ?<br></div><div><br></div><div>Frediano<br></div><div><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 23, 2018 at 5:27 PM, Usepr Xf <span dir="ltr"><<a href="mailto:useprxf@gmail.com" target="_blank" data-mce-href="mailto:useprxf@gmail.com">useprxf@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" data-mce-style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;"><div dir="ltr">I found this code in glz_encoder.c in spice-server:<div><pre style="padding:0px;margin:0px;color:rgb(0,0,0);font-size:13.3333px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial" data-mce-style="padding: 0px; margin: 0px; color: #000000; font-size: 13.3333px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; word-spacing: 0px; background-color: #ffffff; text-decoration-style: initial; text-decoration-color: initial;"><code>static inline void encode_64(Encoder *encoder, uint64_t word)
{
encode_32(encoder, (uint32_t)(word >> 32));
encode_32(encoder, (uint32_t)(word & 0xffffff)); // <----- is it wrong? 0xffffff should be deleted
}</code></pre><br></div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Apr 13, 2018 at 10:04 PM, Frediano Ziglio <span dir="ltr"><<a href="mailto:fziglio@redhat.com" target="_blank" data-mce-href="mailto:fziglio@redhat.com">fziglio@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" data-mce-style="margin: 0 0 0 .8ex; border-left: 1px #ccc solid; padding-left: 1ex;"><span>> Hi all,<br> <br> > Sorry to be a bother.<br> <br> > After a long time running of glz encode&decode (approx. 4hrs), I came across<br> > this error.<br> <br> </span><span>> The higher bits (> 24) of the image id is truncated, which makes dist less<br> </span>> than id . This error seems to happen when the dist across (1<<24)<br><br><br> Is normal that dist is less then id.<br> The id, as far as I know, is incremented from 0 and is a 64 bit, not<br> supposed to overflow, is truncated to get the slot and should not be a<br> problem. The same check "w->images[slot]-><a href="http://hdr.id" rel="noreferrer" target="_blank" data-mce-href="http://hdr.id">hdr.id</a> == id - dist" is done in<br> wait_for_image which should return TRUE and so "image && image-><a href="http://hdr.id" rel="noreferrer" target="_blank" data-mce-href="http://hdr.id">hdr.id</a> == wait->id"<br> should be true.<br><br> Could be that g_coroutine_condition_wait returned FALSE? I think that just calling<br> SPICE_DEBUG is a bug.<br><div class="m_2473460630667174743HOEnZb"><div class="m_2473460630667174743h5"><br> > Can you help me solve this problem?<br> > Many thanks.<br><br> > Best regards,<br> > Zhongqiang Huang<br></div></div></blockquote></div></div></div></div></blockquote></div></div></blockquote></div></body></html>