<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><br></div><style><!--
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:DengXian;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><div class="WordSection1"><p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">Yes. It is some spice code which is calling dump_jpeg.</span></p><p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">After apply this patch, jpeg file can be open by eog.</span></p><p class="MsoNormal"><span lang="EN-US"> </span></p></div></blockquote><div>The call is correct. What is wrong is dump_jpeg which should handle all chunks and not assume that pointer<br></div><div>is raw data.<br></div><div>Thanks for the report.<br></div><div>What are you trying to do dumping jpeg images?<br></div><div><br></div><div>Frediano<br></div><div><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div class="WordSection1"><p class="MsoNormal">发送自<span lang="EN-US"> Windows 10 </span>版<span lang="EN-US"><a href="https://go.microsoft.com/fwlink/?LinkId=550986" target="_blank"><span lang="EN-US"><span lang="EN-US">邮件</span></span></a></span>应用</p><p class="MsoNormal"><span style="font-size:12.0pt;font-family:SimSun" lang="EN-US"> </span></p><div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"><p class="MsoNormal" style="border:none;padding:0cm"><b>发件人<span lang="EN-US">: </span>
</b><span lang="EN-US"><a href="mailto:cfergeau@redhat.com" target="_blank">Christophe Fergeau</a><br>
</span><b>发送时间<span lang="EN-US">: </span></b><span lang="EN-US">2018</span>年<span lang="EN-US">6</span>月<span lang="EN-US">20</span>日<span lang="EN-US"> 17:28<br>
</span><b>收件人<span lang="EN-US">: </span></b><span lang="EN-US"><a href="mailto:KunMing.Xie@hotmail.com" target="_blank"><span lang="EN-US"><span lang="EN-US">谢</span></span><span lang="EN-US"><span lang="EN-US">
</span></span><span lang="EN-US"><span lang="EN-US">昆明</span></span></a><br>
</span><b>抄送<span lang="EN-US">: </span></b><span lang="EN-US"><a href="mailto:spice-devel@lists.freedesktop.org" target="_blank">spice-devel@lists.freedesktop.org</a><br>
</span><b>主题<span lang="EN-US">: </span></b><span lang="EN-US">Re: [Spice-devel] how to open jpg binary file (/tmp/spice_dump/x.jpg)?</span></p></div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:SimSun" lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">Hey,</span></p><p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">On Wed, Jun 20, 2018 at 02:14:54AM +0000,
</span>谢 昆明<span lang="EN-US"> wrote:</span></p><p class="MsoNormal"><span lang="EN-US">> Hey guys. I have dump some jpg file, but I can’t open it with eog.</span></p><p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">I don't understand how this relates to spice? Is this some spice code</span></p><p class="MsoNormal"><span lang="EN-US">which is calling dump_jpeg?</span></p><p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">Christophe</span></p><p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">> </span></p><p class="MsoNormal"><span lang="EN-US">> </span></p><p class="MsoNormal"><span lang="EN-US">> static int jpeg_id = 0;</span></p><p class="MsoNormal"><span lang="EN-US">> static void dump_jpeg(uint8_t* data, int data_size)</span></p><p class="MsoNormal"><span lang="EN-US">> {</span></p><p class="MsoNormal"><span lang="EN-US">> char file_str[200];</span></p><p class="MsoNormal"><span lang="EN-US">> uint32_t id = ++jpeg_id;</span></p><p class="MsoNormal"><span lang="EN-US">> </span></p><p class="MsoNormal"><span lang="EN-US">> #ifdef WIN32</span></p><p class="MsoNormal"><span lang="EN-US">> sprintf(file_str, "c:\\tmp\\spice_dump\\%u.jpg", id);</span></p><p class="MsoNormal"><span lang="EN-US">> #else</span></p><p class="MsoNormal"><span lang="EN-US">> sprintf(file_str, "/tmp/spice_dump/%u.jpg", id);</span></p><p class="MsoNormal"><span lang="EN-US">> #endif</span></p><p class="MsoNormal"><span lang="EN-US">> </span></p><p class="MsoNormal"><span lang="EN-US">> FILE *f = fopen(file_str, "wb");</span></p><p class="MsoNormal"><span lang="EN-US">> if (!f) {</span></p><p class="MsoNormal"><span lang="EN-US">> return;</span></p><p class="MsoNormal"><span lang="EN-US">> }</span></p><p class="MsoNormal"><span lang="EN-US">> </span></p><p class="MsoNormal"><span lang="EN-US">> fwrite(data, 1, data_size, f);</span></p><p class="MsoNormal"><span lang="EN-US">> fclose(f);</span></p><p class="MsoNormal"><span lang="EN-US">> }</span></p><p class="MsoNormal"><span lang="EN-US">> </span></p><p class="MsoNormal"><span lang="EN-US">> </span></p><p class="MsoNormal"><span lang="EN-US">> </span>发送自<span lang="EN-US"> Windows 10
</span>版邮件<span lang="EN-US"><https://go.microsoft.com/fwlink/?LinkId=550986></span>应用</p><p class="MsoNormal"><span lang="EN-US">> </span></p></div></blockquote></div></body></html>